You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/12/28 15:21:40 UTC
[GitHub] [streampipes] smlabt opened a new pull request, #911: chore: remove peer dependencies and use postinstall
smlabt opened a new pull request, #911:
URL: https://github.com/apache/streampipes/pull/911
The two libraries "@streampipes/platform-services" and "@streampipes/shared-ui" are only available locally. So we can not use `npm install` without the flag `--legacy-peer-dependency`. Unfortunatelly dependabot uses `npm install` without this flag and therefore can not be used.
I think a good approach to manage these local libraries would be to use [Nx](https://nx.dev/) which brings support for angular monorepos (https://nx.dev/angular-tutorial/1-code-generation) But to use Nx we need to do some refactoring, I will open a discussion for this.
As a quick workaround I removed the two peer dependencies and added a "postinstall" Scrips which builds and installs the libraries after running `npm install`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti commented on pull request #911: chore: remove peer dependencies and use postinstall
Posted by GitBox <gi...@apache.org>.
bossenti commented on PR #911:
URL: https://github.com/apache/streampipes/pull/911#issuecomment-1366742178
great that you figured that out @smlabt 🚀
I'm looking forward to the Nx discussion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [streampipes] bossenti merged pull request #911: chore: remove peer dependencies and use postinstall
Posted by GitBox <gi...@apache.org>.
bossenti merged PR #911:
URL: https://github.com/apache/streampipes/pull/911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org