You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Andrew Starodub (JIRA)" <ji...@apache.org> on 2010/11/18 00:17:13 UTC
[jira] Created: (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Specified Content-ID is not used when embedding a File object in an HtmlEmail
-----------------------------------------------------------------------------
Key: EMAIL-101
URL: https://issues.apache.org/jira/browse/EMAIL-101
Project: Commons Email
Issue Type: Bug
Affects Versions: 1.2, 1.1, 1.0
Reporter: Andrew Starodub
Fix For: 1.3
When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
I believe this is as simple as changing the last line of .embed(File file, String cid) from:
return embed(new FileDataSource(file), file.getName());
To:
return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siegfried Goeschl reopened EMAIL-101:
-------------------------------------
This innocent change breaks actually the EmailLiveTests ... :-( ... reopening to investigate the problem
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Assignee: Siegfried Goeschl
> Fix For: 1.3
>
> Attachments: HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] [Updated] (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siegfried Goeschl updated EMAIL-101:
------------------------------------
Priority: Minor (was: Major)
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Assignee: Siegfried Goeschl
> Priority: Minor
> Fix For: 1.3
>
> Attachments: HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Siegfried Goeschl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siegfried Goeschl updated EMAIL-101:
------------------------------------
Attachment: EMAIL-101.patch
Updated patch (hackergarden vienna)
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Assignee: Siegfried Goeschl
> Priority: Minor
> Fix For: 1.3
>
> Attachments: EMAIL-101.patch, HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Thomas Neidhart (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Neidhart updated EMAIL-101:
----------------------------------
Attachment: EMAIL-101_encoding.patch
Added an updated patch for the broken inline images. The cid has to be encoded properly (see http://tools.ietf.org/html/rfc2392).
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Assignee: Siegfried Goeschl
> Priority: Minor
> Fix For: 1.3
>
> Attachments: EMAIL-101_encoding.patch, EMAIL-101.patch, HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siegfried Goeschl resolved EMAIL-101.
-------------------------------------
Resolution: Fixed
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Assignee: Siegfried Goeschl
> Fix For: 1.3
>
> Attachments: HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Andrew Starodub (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Starodub updated EMAIL-101:
----------------------------------
Attachment: HtmlEmail.patch
Attaching patch file to correct return line in HtmlEmail.embed(File file, String cid)
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Fix For: 1.3
>
> Attachments: HtmlEmail.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12934761#action_12934761 ]
Siegfried Goeschl commented on EMAIL-101:
-----------------------------------------
Hi Andrew, thanks for the patch ...
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Assignee: Siegfried Goeschl
> Fix For: 1.3
>
> Attachments: HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (EMAIL-101) Specified Content-ID is not used when
embedding a File object in an HtmlEmail
Posted by "Andrew Starodub (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/EMAIL-101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Starodub updated EMAIL-101:
----------------------------------
Attachment: HtmlEmailTest.patch
Attaching a patch that includes a regression test for making sure the returned CID is the same as the user-specified CID.
> Specified Content-ID is not used when embedding a File object in an HtmlEmail
> -----------------------------------------------------------------------------
>
> Key: EMAIL-101
> URL: https://issues.apache.org/jira/browse/EMAIL-101
> Project: Commons Email
> Issue Type: Bug
> Affects Versions: 1.0, 1.1, 1.2
> Reporter: Andrew Starodub
> Fix For: 1.3
>
> Attachments: HtmlEmail.patch, HtmlEmailTest.patch
>
>
> When calling the .embed(File file, String cid) method on HtmlEmail, the cid argument is never used within the method.
> Consequently, even when the user specifies a Content-ID for the embedded File, a new randomly generated Content-ID is generated every time.
> I believe this is as simple as changing the last line of .embed(File file, String cid) from:
> return embed(new FileDataSource(file), file.getName());
> To:
> return embed(new FileDataSource(file), file.getName(), cid);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.