You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/10/05 20:17:04 UTC

[GitHub] [beam] tvalentyn commented on a diff in pull request #23070: Support TIMESTAMP type in BigQueryIO with BEAM_ROW output type, and in read_gbq

tvalentyn commented on code in PR #23070:
URL: https://github.com/apache/beam/pull/23070#discussion_r988316445


##########
sdks/python/apache_beam/io/gcp/bigquery_schema_tools.py:
##########
@@ -38,8 +39,10 @@
     "STRING": str,
     "INTEGER": np.int64,
     "FLOAT64": np.float64,
+    "FLOAT": np.float64,
     "BOOLEAN": bool,
     "BYTES": bytes,
+    "TIMESTAMP": apache_beam.utils.timestamp.Timestamp.from_utc_datetime

Review Comment:
   cc: @Abacn @TheNeuralBit who worked on  https://github.com/apache/beam/blob/master/sdks/python/apache_beam/typehints/schemas.py#L36-L37 
   
   Folks, do you know what (if any) aspects we need to take care of for this change to correctly work with schemas & xlang?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org