You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by jo...@apache.org on 2018/01/03 03:52:45 UTC
nifi git commit: NIFI-4729: This closes #2366. ConvertJSONToSQL
converted boolean values in reverse
Repository: nifi
Updated Branches:
refs/heads/master 9f919b9b6 -> 195958638
NIFI-4729: This closes #2366. ConvertJSONToSQL converted boolean values in reverse
Signed-off-by: joewitt <jo...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/nifi/repo
Commit: http://git-wip-us.apache.org/repos/asf/nifi/commit/19595863
Tree: http://git-wip-us.apache.org/repos/asf/nifi/tree/19595863
Diff: http://git-wip-us.apache.org/repos/asf/nifi/diff/19595863
Branch: refs/heads/master
Commit: 19595863894a762b42fe7d6226835aacf207dcb6
Parents: 9f919b9
Author: Koji Kawamura <ij...@apache.org>
Authored: Wed Jan 3 09:03:14 2018 +0900
Committer: joewitt <jo...@apache.org>
Committed: Tue Jan 2 22:01:40 2018 -0500
----------------------------------------------------------------------
.../org/apache/nifi/processors/standard/ConvertJSONToSQL.java | 2 +-
.../org/apache/nifi/processors/standard/TestConvertJSONToSQL.java | 3 +--
2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/nifi/blob/19595863/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
----------------------------------------------------------------------
diff --git a/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java b/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
index 638ec9d..9705dc0 100755
--- a/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
+++ b/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ConvertJSONToSQL.java
@@ -547,7 +547,7 @@ public class ConvertJSONToSQL extends AbstractProcessor {
case Types.NUMERIC:
if (fieldNode.isBoolean()) {
// Convert boolean to number representation for databases those don't support boolean type.
- fieldValue = fieldNode.asBoolean() ? "0" : "1";
+ fieldValue = fieldNode.asBoolean() ? "1" : "0";
}
break;
http://git-wip-us.apache.org/repos/asf/nifi/blob/19595863/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestConvertJSONToSQL.java
----------------------------------------------------------------------
diff --git a/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestConvertJSONToSQL.java b/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestConvertJSONToSQL.java
index 8a03a81..26f04a2 100755
--- a/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestConvertJSONToSQL.java
+++ b/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestConvertJSONToSQL.java
@@ -205,9 +205,8 @@ public class TestConvertJSONToSQL {
out.assertAttributeEquals("sql.args.1.value", "1");
out.assertAttributeEquals("sql.args.2.type", String.valueOf(java.sql.Types.VARCHAR));
out.assertAttributeEquals("sql.args.2.value", "Bool");
- // Boolean value 'true' is converted to '0'
out.assertAttributeEquals("sql.args.3.type", String.valueOf(java.sql.Types.INTEGER));
- out.assertAttributeEquals("sql.args.3.value", "0");
+ out.assertAttributeEquals("sql.args.3.value", "1");
out.assertContentEquals("INSERT INTO PERSONS (ID, NAME, CODE) VALUES (?, ?, ?)");
}