You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2015/09/14 11:25:31 UTC

[GitHub] incubator-zeppelin pull request: Remove double HomeCtrl, clean Hom...

GitHub user corneadoug opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/307

    Remove double HomeCtrl, clean HomeCtrl to vm

    HomeCtrl was inserted twice, making extra API calls.
    This PR also replace the last $scope values to vm.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/corneadoug/incubator-zeppelin fix/doubleHomeCtrl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/307.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #307
    
----
commit 83d4b66739977b78d6040ef53102d9dffe16d862
Author: Damien Corneau <co...@gmail.com>
Date:   2015-09-14T09:19:31Z

    Remove double HomeCtrl, clean HomeCtrl to vm

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Remove double HomeCtrl, clean Hom...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-zeppelin/pull/307


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Remove double HomeCtrl, clean Hom...

Posted by corneadoug <gi...@git.apache.org>.

Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/307#issuecomment-140260516
  
    Ready to Merge


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---