[GitHub] [incubator-celeborn] waitinfuture commented on a diff in pull request #1135: [CELEBORN-189][IMPROVEMENT] PushDataFailedSlave should add slave worker to blacklist

[GitBox <gi...@apache.org>]

waitinfuture commented on code in PR #1135:
URL: https://github.com/apache/incubator-celeborn/pull/1135#discussion_r1062093221


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -529,6 +529,7 @@ class CelebornConf(loadDefaults: Boolean) extends Cloneable with Logging with Se
   def shuffleExpiredCheckIntervalMs: Long = get(SHUFFLE_EXPIRED_CHECK_INTERVAL)
   def workerExcludedCheckIntervalMs: Long = get(WORKER_EXCLUDED_INTERVAL)
   def workerExcludedExpireTimeout: Long = get(WORKER_EXCLUDED_EXPIRE_TIMEOUT)
+  def workerExcludedSlaveEnabled: Boolean = get(WORKER_EXCLUDE_SLAVE_ENABLED)

Review Comment:
   blacklistSlaveEnabled



##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1354,6 +1355,15 @@ object CelebornConf extends Logging {
       .timeConf(TimeUnit.MILLISECONDS)
       .createWithDefaultString("600s")
 
+  val WORKER_EXCLUDE_SLAVE_ENABLED: ConfigEntry[Boolean] =

Review Comment:
   BLACKLIST_SLAVE_ENABLED



##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -1354,6 +1355,15 @@ object CelebornConf extends Logging {
       .timeConf(TimeUnit.MILLISECONDS)
       .createWithDefaultString("600s")
 
+  val WORKER_EXCLUDE_SLAVE_ENABLED: ConfigEntry[Boolean] =
+    buildConf("celeborn.worker.excluded.slave.enabled")

Review Comment:
   better to rename to celeborn.client.blacklistSlave.enabled



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org