You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "Michael Dürig (JIRA)" <ji...@apache.org> on 2018/06/19 11:46:00 UTC

[jira] [Commented] (OAK-7551) The compaction deadline should be reset at each execution

    [ https://issues.apache.org/jira/browse/OAK-7551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16516975#comment-16516975 ] 

Michael Dürig commented on OAK-7551:
------------------------------------

Nice solution! The only thing I'm wondering about is whether the behaviour of {{ShortCircuitCanceller}} shouldn't better be the default behaviour of all {{Canceller}} implementations? 

> The compaction deadline should be reset at each execution
> ---------------------------------------------------------
>
>                 Key: OAK-7551
>                 URL: https://issues.apache.org/jira/browse/OAK-7551
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-tar
>            Reporter: Francesco Mari
>            Assignee: Francesco Mari
>            Priority: Major
>             Fix For: 1.10, 1.9.5
>
>
> The compaction deadline, represented by {{CancelCompactionSupplier}}, should be reset before each usage with a proper timeout. This doesn't happen at the beginning of the compaction phase in {{AbstractCompactionStrategy#compact}}, which results in the timeout condition to be ignored.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)