[GitHub] [beam] TheNeuralBit commented on a diff in pull request #17459: [BEAM-13983] Small changes to sklearn runinference

[GitBox <gi...@apache.org>]

TheNeuralBit commented on code in PR #17459:
URL: https://github.com/apache/beam/pull/17459#discussion_r858069139


##########
sdks/python/apache_beam/ml/inference/sklearn_loader.py:
##########
@@ -70,9 +70,11 @@ def load_model(self):
       return pickle.load(file)
     elif self._model_file_type == ModelFileType.JOBLIB:
       if not joblib:
-        raise ImportError('Joblib not available in SklearnModelLoader.')
+        raise ImportError('Could not import joblib in this execution'
+            ' environment. https://beam.apache.org/documentation/'
+            'sdks/python-pipeline-dependencies/')

Review Comment:
   nit: I might add a little more context here (I'm fine if you'd rather keep it as-is though)
   
   ```suggestion
           raise ImportError('Could not import joblib in this execution'
               ' environment. For help with managing dependencies on Python workers see https://beam.apache.org/documentation/sdks/python-pipeline-dependencies/')
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org