You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/13 17:14:12 UTC
[GitHub] [arrow] jonathan-albrecht-ibm opened a new pull request #9195: ARROW-11171: [Go] Fix building on s390x with noasm
jonathan-albrecht-ibm opened a new pull request #9195:
URL: https://github.com/apache/arrow/pull/9195
This PR fixes building the Go component on the s390x platform with the `noasm` build tag.
Before this change, running `make test-noasm` would fail with:
```go
$ make test-noasm
go test -tags='noasm' ./...
# github.com/apache/arrow/go/arrow/math
math/float64_s390x.go:21:6: initFloat64Go redeclared in this block
previous declaration at math/float64_noasm.go:23:6
math/int64_s390x.go:21:6: initInt64Go redeclared in this block
previous declaration at math/int64_noasm.go:23:6
math/math_s390x.go:24:6: initGo redeclared in this block
previous declaration at math/math_noasm.go:25:6
math/uint64_s390x.go:21:6: initUint64Go redeclared in this block
previous declaration at math/uint64_noasm.go:23:6
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jonathan-albrecht-ibm commented on pull request #9195: ARROW-11171: [Go] Fix building on s390x with noasm
Posted by GitBox <gi...@apache.org>.
jonathan-albrecht-ibm commented on pull request #9195:
URL: https://github.com/apache/arrow/pull/9195#issuecomment-761176372
> Should we also update our CI scripts for `noasm` case?
>
> * https://github.com/apache/arrow/blob/master/ci/scripts/go_build.sh
> * https://github.com/apache/arrow/blob/master/ci/scripts/go_test.sh
Not sure if I can answer this question and apologies if its meant for someone else but I don't think the CI scripts need to change, at least not as part of this PR. `noasm` is not the common case on 390x but since its supported on other archs I wanted to make sure it is on s390x as well. It came up while trying to build another project that depends on arrow that had specified `noasm` and so it didn't build out of the box.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9195: ARROW-11171: [Go] Fix building on s390x with noasm
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9195:
URL: https://github.com/apache/arrow/pull/9195#issuecomment-759658273
https://issues.apache.org/jira/browse/ARROW-11171
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #9195: ARROW-11171: [Go] Fix building on s390x with noasm
Posted by GitBox <gi...@apache.org>.
kou closed pull request #9195:
URL: https://github.com/apache/arrow/pull/9195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #9195: ARROW-11171: [Go] Fix building on s390x with noasm
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #9195:
URL: https://github.com/apache/arrow/pull/9195#issuecomment-759784060
Should we also update our CI scripts for `noasm` case?
* https://github.com/apache/arrow/blob/master/ci/scripts/go_build.sh
* https://github.com/apache/arrow/blob/master/ci/scripts/go_test.sh
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org