You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@poi.apache.org by fa...@apache.org on 2022/07/27 09:02:16 UTC

svn commit: r1903048 - in /poi/trunk/poi/src: main/java/org/apache/poi/ss/formula/WorkbookEvaluator.java test/java/org/apache/poi/ss/formula/TestFormulaEval.java

Author: fanningpj
Date: Wed Jul 27 09:02:15 2022
New Revision: 1903048

URL: http://svn.apache.org/viewvc?rev=1903048&view=rev
Log:
revert accidental changes

Modified:
    poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/WorkbookEvaluator.java
    poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/TestFormulaEval.java

Modified: poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/WorkbookEvaluator.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/WorkbookEvaluator.java?rev=1903048&r1=1903047&r2=1903048&view=diff
==============================================================================
--- poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/WorkbookEvaluator.java (original)
+++ poi/trunk/poi/src/main/java/org/apache/poi/ss/formula/WorkbookEvaluator.java Wed Jul 27 09:02:15 2022
@@ -75,12 +75,12 @@ public final class WorkbookEvaluator {
     /**
      * whether print detailed messages about the next formula evaluation
      */
-    private boolean dbgEvaluationOutputForNextEval = true;
+    private boolean dbgEvaluationOutputForNextEval;
 
     // special logger for formula evaluation output (because of possibly very large output)
     private final Logger EVAL_LOG = LogManager.getLogger("POI.FormulaEval");
     // current indent level for evaluation; negative value for no output
-    private int dbgEvaluationOutputIndent = 1;
+    private int dbgEvaluationOutputIndent = -1;
 
     /**
      * @param udfFinder pass {@code null} for default (AnalysisToolPak only)
@@ -376,7 +376,7 @@ public final class WorkbookEvaluator {
         if (dbgEvaluationOutputForNextEval) {
             // first evaluation call when ouput is desired, so iit. this evaluator instance
             dbgEvaluationOutputIndent = 1;
-            //dbgEvaluationOutputForNextEval = true;
+            dbgEvaluationOutputForNextEval = true;
         }
         if (dbgEvaluationOutputIndent > 0) {
             // init. indent string to needed spaces (create as substring from very long space-only string;

Modified: poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/TestFormulaEval.java
URL: http://svn.apache.org/viewvc/poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/TestFormulaEval.java?rev=1903048&r1=1903047&r2=1903048&view=diff
==============================================================================
--- poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/TestFormulaEval.java (original)
+++ poi/trunk/poi/src/test/java/org/apache/poi/ss/formula/TestFormulaEval.java Wed Jul 27 09:02:15 2022
@@ -74,7 +74,7 @@ class TestFormulaEval {
         }
     }
 
-    //@Disabled("currently causes a StackOverflowError")
+    @Disabled("currently causes a StackOverflowError")
     @Test
     void testBug66152() throws IOException {
         try (HSSFWorkbook wb = new HSSFWorkbook()) {



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@poi.apache.org
For additional commands, e-mail: commits-help@poi.apache.org