You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@skywalking.apache.org by wu...@apache.org on 2018/09/13 05:10:57 UTC

[incubator-skywalking] branch new-indicator-core updated: Block 2 unaccessible methods.

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch new-indicator-core
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git


The following commit(s) were added to refs/heads/new-indicator-core by this push:
     new 9a9746b  Block 2 unaccessible methods.
9a9746b is described below

commit 9a9746b0f257b3a8cc368dc21b58a716ec0c4a0c
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Thu Sep 13 13:10:51 2018 +0800

    Block 2 unaccessible methods.
---
 .../org/apache/skywalking/oap/server/core/source/ServiceComponent.java | 3 ++-
 .../org/apache/skywalking/oap/server/core/source/ServiceMapping.java   | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceComponent.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceComponent.java
index 6241d7b..d2f0dff 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceComponent.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceComponent.java
@@ -19,6 +19,7 @@
 package org.apache.skywalking.oap.server.core.source;
 
 import lombok.*;
+import org.apache.skywalking.oap.server.core.UnexpectedException;
 import org.apache.skywalking.oap.server.core.source.annotation.SourceType;
 
 /**
@@ -33,7 +34,7 @@ public class ServiceComponent extends Source {
 
 
     @Override public String getEntityId() {
-        return String.valueOf(serviceId);
+        throw new UnexpectedException("ServiceMapping doesn't support getEntityId");
     }
 
 
diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceMapping.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceMapping.java
index 9aaff42..83bd63a 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceMapping.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceMapping.java
@@ -19,6 +19,7 @@
 package org.apache.skywalking.oap.server.core.source;
 
 import lombok.*;
+import org.apache.skywalking.oap.server.core.UnexpectedException;
 import org.apache.skywalking.oap.server.core.source.annotation.SourceType;
 
 /**
@@ -33,7 +34,7 @@ public class ServiceMapping extends Source {
 
 
     @Override public String getEntityId() {
-        return String.valueOf(serviceId);
+        throw new UnexpectedException("ServiceMapping doesn't support getEntityId");
     }
 
     @Getter @Setter private int serviceId;