You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/11 10:59:43 UTC

[GitHub] [shardingsphere] weihubeats opened a new pull request, #16736: Add test cases for RuleAlteredDetectorFactory

weihubeats opened a new pull request, #16736:
URL: https://github.com/apache/shardingsphere/pull/16736

   Fixes #16718.
   
   Changes proposed in this pull request:
   -
   -
   -
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] weihubeats commented on pull request #16736: Add test cases for RuleAlteredDetectorFactory

Posted by GitBox <gi...@apache.org>.
weihubeats commented on PR #16736:
URL: https://github.com/apache/shardingsphere/pull/16736#issuecomment-1095901775

   I want to add more test cases, but I can't use the implementation classes of RuleConfiguration and YamlRuleConfiguration, because this module does not depend on his implementation module, what should I do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu merged pull request #16736: Add test cases for RuleAlteredDetectorFactory

Posted by GitBox <gi...@apache.org>.
terrymanu merged PR #16736:
URL: https://github.com/apache/shardingsphere/pull/16736


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on pull request #16736: Add test cases for RuleAlteredDetectorFactory

Posted by GitBox <gi...@apache.org>.
yx9o commented on PR #16736:
URL: https://github.com/apache/shardingsphere/pull/16736#issuecomment-1095897604

   @weihubeats Hi, is it possible to consider adding more cases, such as: `assertTrue(ruleAlteredDetector.isPresent())` scene.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yx9o commented on pull request #16736: Add test cases for RuleAlteredDetectorFactory

Posted by GitBox <gi...@apache.org>.
yx9o commented on PR #16736:
URL: https://github.com/apache/shardingsphere/pull/16736#issuecomment-1095924050

   @weihubeats Yes, you are right, maybe we can use the implementation class by writing the test class under the `shardingsphere-pipeline-test` module.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org