You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/04/23 19:45:53 UTC
[kudu-CR] KUDU-2796: Fix HDFS path handling
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13089
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
KUDU-2796: Fix HDFS path handling
This patch changes the SessionIO class to use only
Hadoop Path’s.
Before it was converting between
Hadoop Path objects and Java Path objects which
seems to cause issues with the NameService URI.
Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
2 files changed, 11 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/13089/1
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] KUDU-2796: Fix HDFS path handling
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13089 )
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
Patch Set 2: Verified+1 Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 21:11:40 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2796: Fix HDFS path handling
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13089 )
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13089/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13089/1//COMMIT_MSG@10
PS1, Line 10: Path’s
> Nit: "Paths" or "Path instances"?
Done
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 21:10:35 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2796: Fix HDFS path handling
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13089 )
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
KUDU-2796: Fix HDFS path handling
This patch changes the SessionIO class to use only
Hadoop Paths instances.
Before it was converting between
Hadoop Path objects and Java Path objects which
seems to cause issues with the NameService URI.
Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Reviewed-on: http://gerrit.cloudera.org:8080/13089
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
2 files changed, 11 insertions(+), 16 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2796: Fix HDFS path handling
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13089 )
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 20:43:09 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2796: Fix HDFS path handling
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13089 )
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13089/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13089/1//COMMIT_MSG@10
PS1, Line 10: Path’s
Nit: "Paths" or "Path instances"?
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 20:31:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2796: Fix HDFS path handling
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Hello Will Berkeley, Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13089
to look at the new patch set (#2).
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
KUDU-2796: Fix HDFS path handling
This patch changes the SessionIO class to use only
Hadoop Paths instances.
Before it was converting between
Hadoop Path objects and Java Path objects which
seems to cause issues with the NameService URI.
Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
---
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/BackupGraph.scala
M java/kudu-backup/src/main/scala/org/apache/kudu/backup/SessionIO.scala
2 files changed, 11 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/13089/2
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] KUDU-2796: Fix HDFS path handling
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13089 )
Change subject: KUDU-2796: Fix HDFS path handling
......................................................................
Patch Set 1:
Carrying the +2 forward through a simple commit message change.
--
To view, visit http://gerrit.cloudera.org:8080/13089
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I565d753d4ac70597dc9d1cb151c51e84b8db87f5
Gerrit-Change-Number: 13089
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Tue, 23 Apr 2019 21:11:30 +0000
Gerrit-HasComments: No