You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/01 13:54:44 UTC

[GitHub] [tvm] Mousius opened a new pull request #8898: Move to new style issue template system

Mousius opened a new pull request #8898:
URL: https://github.com/apache/tvm/pull/8898


   This lets us have a template for each type of issue, notably this includes a template for requesting a CI image update.
   
   I can't find a decent way of testing this but GitHub does seem to have acknowledged they are issue templates here: https://github.com/Mousius/tvm/blob/issue-templates/.github/ISSUE_TEMPLATE/bug-report.md
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] jcf94 merged pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
jcf94 merged pull request #8898:
URL: https://github.com/apache/tvm/pull/8898


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Mousius commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700457623



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       By the power of the thesaurus I have renamed it `CI Problem`, though keen to hear whether people think we need another category.
   
   On the labels point, the config appears to let me set labels, so I'm curious if it'll actually apply them when we open those issue types. When we see if that works we can decide if we want to try more of it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700410478



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       `[CI Image]` looks good to me. `[CI Issue]` looks a bit fanny tho, as we are already creating an "issue" here lol
   I'm fine if others feel CI failures are a kind of bugs. The downside is I don't think people can add labels to an issue by themselves unless they have the write permission (i.e., committer). It means we will need a committer to help add labels manually for created issues; otherwise we will need a bot to automatically add labels based on the issue content.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Mousius commented on pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
Mousius commented on pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#issuecomment-910308841


   @junrushao1994 @jroesch 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700410478



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       `[CI Image]` looks good to me. `[CI Issue]` looks a bit funny tho, as we are already creating an "issue" here lol
   I'm fine if others feel CI failures are a kind of bugs. The downside is I don't think people can add labels to an issue by themselves unless they have the write permission (i.e., committer). It means we will need a committer to help add labels manually for created issues; otherwise we will need a bot to automatically add labels based on the issue content.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700576328



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       I'm not sure either. Maybe someone else could confirm? Anyways, I'm good with the current change.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Mousius commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700405281



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       I was inclined to suggest we limit the amount of issue types but then this PR failed CI, so I've changed this to `[CI Image] ` and created a `[CI Issue] ` template as well. I don't think that's too many for people to pick through?
   
   It's also worth noting we can use `label` as well as the `title` here if we wanted to create labels for filtering on, I would need someones help to make appropriate labels though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700384222



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       On the other hand, [Docker] is a confusing name too, which might sound like docker-related but itโ€™s actually CI upgrade ๐Ÿ˜†




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] Mousius commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
Mousius commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r702032530



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       Following up on this thread, a new bug was raised (https://github.com/apache/tvm/issues/8925) which had the label auto-applied so the config here overrides the need for a committer :tada:




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700384743



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       What about [CI Image]




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] comaniac commented on a change in pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
comaniac commented on a change in pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#discussion_r700381240



##########
File path: .github/ISSUE_TEMPLATE/ci-update.md
##########
@@ -0,0 +1,29 @@
+---
+name: "\U0001F40B Update CI Docker Image"
+about: Provide information on CI Docker Images requiring updates
+title: "[CI] "

Review comment:
       I would suggest using other tags like `[Docker]` or something else for updating CI docker images, because `[CI]` looks more like an CI issue (e.g., flaky test, machine down, etc) at the first glance. Since CI issue is not really a bug, we could still have a CI issue template to let users report CI running issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [tvm] junrushao1994 commented on pull request #8898: Move to new style issue template system

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #8898:
URL: https://github.com/apache/tvm/pull/8898#issuecomment-910437701


   This looks nice! CC: @tqchen


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org