You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "beliefer (via GitHub)" <gi...@apache.org> on 2024/01/10 04:43:42 UTC

[PR] [WIP][SQL][CONNECT] Resolve inappropriate use of AtomicInteger [spark]

beliefer opened a new pull request, #44659:
URL: https://github.com/apache/spark/pull/44659

   ### What changes were proposed in this pull request?
   This PR propose to resolve inappropriate use of `AtomicInteger`.
   
   
   ### Why are the changes needed?
   `AtomicInteger` itself is thread safe and is used to address the atomicity of operations such as increment or decrement.
   This PR resolves some inappropriate case. such as:
   
   - `AtomicInteger` used as a local variable.
   - Decorate `AtomicInteger` with `var`.
   - Some unused `AtomicInteger` variable.
   
   
   ### Does this PR introduce _any_ user-facing change?
   'No'.
   
   
   ### How was this patch tested?
   GA tests.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   'No'.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [WIP][SQL][CONNECT] Resolve inappropriate use of AtomicInteger [spark]

Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer closed pull request #44659: [WIP][SQL][CONNECT] Resolve inappropriate use of AtomicInteger
URL: https://github.com/apache/spark/pull/44659


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org