[GitHub] [arrow] kou opened a new issue, #14906: [C++][CMake] Use cpp/src/arrow/util/config.h.cmake instead of add_defintions() for ARROW_WITH_${COMPRESESION}

[GitBox <gi...@apache.org>]

kou opened a new issue, #14906:
URL: https://github.com/apache/arrow/issues/14906

   ### Describe the enhancement requested
   
   For example, `ARROW_WITH_ZLIB`, `ARROW_WITH_ZSTD` and so on.
   
   In general, we should not use `add_definitions()` in modern CMake because its scope is directory. Directory scope may introduce implicit unexpected definitions. We should use CMake target or something instead.
   
   If we use `cpp/src/arrow/util/config.h.cmake`, Apache Arrow C++ users can also use `ARROW_WITH_${COMPRESSION}`.
   
   ### Component(s)
   
   C++


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [C++][CMake] Use cpp/src/arrow/util/config.h.cmake instead of add_defintions() for ARROW_WITH_${COMPRESESION} [arrow]

["thisisnic (via GitHub)" <gi...@apache.org>]

thisisnic commented on issue #14906:
URL: https://github.com/apache/arrow/issues/14906#issuecomment-3921582302

   This issue has been marked as stale because it has had no activity in the past 2 years. Please remove the stale label or comment below, or this issue will be closed in 14 days.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org