[GitHub] [flink] dianfu commented on a change in pull request #9140: [FLINK-13299][travis][python] fix flink-python failed on Travis because of incompatible virtualenv

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #9140: [FLINK-13299][travis][python] fix flink-python failed on Travis because of incompatible virtualenv
URL: https://github.com/apache/flink/pull/9140#discussion_r304382809
 
 

 ##########
 File path: flink-python/dev/lint-python.sh
 ##########
 @@ -213,6 +213,10 @@ function install_tox() {
         fi
     fi
 
+    # virtualenv 16.6.2 released in 2019-07-14 is incompatible with py27 and py34,
+    # force install an older version(16.0.0) to avoid this problem.
+    $CONDA_PATH install -p $CONDA_HOME -c conda-forge virtualenv=16.0.0 -y -q 2>&1 >/dev/null
+    
     $CONDA_PATH install -p $CONDA_HOME -c conda-forge tox -y -q 2>&1 >/dev/null
 
 Review comment:
   What about changing to
   `$CONDA_PATH install -p $CONDA_HOME -c conda-forge virtualenv=16.0.0 tox -y -q 2>&1 >/dev/null`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services