You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/04/21 09:09:57 UTC
[GitHub] [hbase-operator-tools] nyl3532016 opened a new pull request #58: remove FSUtils.checkAccess, replace with FileSystem.access in HBCK
nyl3532016 opened a new pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] nyl3532016 commented on a change in pull request #58: HBASE-24222 remove FSUtils.checkAccess and replace with FileSystem.access in HBCK
Posted by GitBox <gi...@apache.org>.
nyl3532016 commented on a change in pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58#discussion_r412618481
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java
##########
@@ -2450,7 +2450,7 @@ private void checkAndFixTableStates() throws IOException {
}
}
- private void preCheckPermission() throws IOException, AccessDeniedException {
+ private void preCheckPermission() throws IOException, AccessControlException {
Review comment:
printUsageAndExit do not invoke preCheckPermission ? I can not find the invoke
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] nyl3532016 edited a comment on pull request #58: HBASE-24222 remove FSUtils.checkAccess and replace with FileSystem.access in HBCK
Posted by GitBox <gi...@apache.org>.
nyl3532016 edited a comment on pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58#issuecomment-619475950
@liuml07 @jojochuang please help merge this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] liuml07 commented on pull request #58: HBASE-24222 remove FSUtils.checkAccess and replace with FileSystem.access in HBCK
Posted by GitBox <gi...@apache.org>.
liuml07 commented on pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58#issuecomment-619477870
> @liuml07 @jojochuang please help merge this one
I don’t have commit access. We can ping @Apache9 to have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] jojochuang commented on a change in pull request #58: HBASE-24222 remove FSUtils.checkAccess and replace with FileSystem.access in HBCK
Posted by GitBox <gi...@apache.org>.
jojochuang commented on a change in pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58#discussion_r412302488
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java
##########
@@ -2450,7 +2450,7 @@ private void checkAndFixTableStates() throws IOException {
}
}
- private void preCheckPermission() throws IOException, AccessDeniedException {
+ private void preCheckPermission() throws IOException, AccessControlException {
Review comment:
In printUsageAndExit() which invokes preCheckPermission(), should it also update the following catch clause to catch AccessControlException instead?
`
} catch (AccessDeniedException ace) {
`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] nyl3532016 commented on pull request #58: HBASE-24222 remove FSUtils.checkAccess and replace with FileSystem.access in HBCK
Posted by GitBox <gi...@apache.org>.
nyl3532016 commented on pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58#issuecomment-619475950
@liuml07 @jojochuang please hep merge this one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] liuml07 commented on a change in pull request #58: HBASE-24222 remove FSUtils.checkAccess and replace with FileSystem.access in HBCK
Posted by GitBox <gi...@apache.org>.
liuml07 commented on a change in pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58#discussion_r412693527
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java
##########
@@ -2450,7 +2450,7 @@ private void checkAndFixTableStates() throws IOException {
}
}
- private void preCheckPermission() throws IOException, AccessDeniedException {
+ private void preCheckPermission() throws IOException, AccessControlException {
Review comment:
The only place I found was `HBaseFsck.java`, which deals with this the same as generic IOE (simply `exit`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hbase-operator-tools] jatsakthi commented on pull request #58: HBASE-24222 remove FSUtils.checkAccess and replace with FileSystem.access in HBCK
Posted by GitBox <gi...@apache.org>.
jatsakthi commented on pull request #58:
URL: https://github.com/apache/hbase-operator-tools/pull/58#issuecomment-622521855
+1. Thanks for the contribution @nyl3532016 and the review @liuml07 & @jojochuang . Let me merge this one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org