You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/03/14 13:28:20 UTC

[GitHub] [incubator-nuttx-apps] litong0518 opened a new pull request #1073: examples/rpmsgsocket: Fix rpmsg example's bug

litong0518 opened a new pull request #1073:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1073


   ## Summary
   Fix rpmsg example's bug
   
   ## Impact
   N/A
   
   ## Testing
   N/A
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1073: examples/rpmsgsocket: Fix rpmsg example's bug

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1073:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1073#discussion_r826266676



##########
File path: examples/rpmsgsocket/rpsock_server.c
##########
@@ -315,7 +341,6 @@ static int rpsock_dgram_server(int argc, char *argv[])
 
   args->fd       = fd;
   args->nonblock = nonblock;
-  args->skippoll = true;

Review comment:
       Yeah. I see now. Sometimes reviewing from a mobile device is tricky :)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #1073: examples/rpmsgsocket: Fix rpmsg example's bug

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1073:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1073


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #1073: examples/rpmsgsocket: Fix rpmsg example's bug

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #1073:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1073#discussion_r826163533



##########
File path: examples/rpmsgsocket/rpsock_server.c
##########
@@ -315,7 +341,6 @@ static int rpsock_dgram_server(int argc, char *argv[])
 
   args->fd       = fd;
   args->nonblock = nonblock;
-  args->skippoll = true;

Review comment:
       Is `skippoll` still used? Maybe we can remove it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #1073: examples/rpmsgsocket: Fix rpmsg example's bug

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1073:
URL: https://github.com/apache/incubator-nuttx-apps/pull/1073#discussion_r826261486



##########
File path: examples/rpmsgsocket/rpsock_server.c
##########
@@ -315,7 +341,6 @@ static int rpsock_dgram_server(int argc, char *argv[])
 
   args->fd       = fd;
   args->nonblock = nonblock;
-  args->skippoll = true;

Review comment:
       @pkarashchenko It's already removed here: https://github.com/apache/incubator-nuttx-apps/pull/1073/files#diff-ecc3b29b961b716dc9d3a3108645bfc63f186d1cbe9d1acefcb7fbe21716b28fL46.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org