You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/12/10 19:18:00 UTC
[jira] [Commented] (AVRO-2026) Incorporate valgrind memory testing
for C
[ https://issues.apache.org/jira/browse/AVRO-2026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715405#comment-16715405 ]
ASF subversion and git services commented on AVRO-2026:
-------------------------------------------------------
Commit 7fbedbb8923bb203409f5d5576a38ac70aba9f4b in avro's branch refs/heads/master from John Gill
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=7fbedbb ]
[AVRO-2026] Add valgrind to c tests
This closes #218
Squashed merge of:
Don't clean after test. Allow review of memcheck files
Add valgrind to tests
Correct memory leaks in tests
> Incorporate valgrind memory testing for C
> -----------------------------------------
>
> Key: AVRO-2026
> URL: https://issues.apache.org/jira/browse/AVRO-2026
> Project: Apache Avro
> Issue Type: Improvement
> Components: c
> Reporter: John Gill
> Priority: Major
> Fix For: 1.8.3
>
> Attachments: AVRO-2026.patch
>
>
> With the work done for AVRO-1167 & AVRO-766 in identifying memory leaks decided to make it a standard part of the testing framework. This issue requires https://github.com/apache/avro/pull/218 otherwise test_avro_schema and test_avro_values fail due to to avro_schema_copy calls.
> Adding valgrind tool to the docker container
> Adding valgrind to CMakeLists.txt to optionally do valgrind testing if the tool is found
> Cleaning up existing tests that were failing due to not properly cleaning up memory
> Lastly, as part of ./build.sh test for lang/c do not remove the build/c directory. The memcheck output is kept so that memory leak issues can be reviewed and addressed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)