You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "abhagraw (via GitHub)" <gi...@apache.org> on 2023/03/29 04:24:59 UTC
[GitHub] [druid] abhagraw opened a new pull request, #13997: S3minio
abhagraw opened a new pull request, #13997:
URL: https://github.com/apache/druid/pull/13997
Using MinIO to emulate s3 storage and running s3 deep storage ITs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers commented on a diff in pull request #13997: Using MinIO to run S3DeepStorage ITs
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers commented on code in PR #13997:
URL: https://github.com/apache/druid/pull/13997#discussion_r1152182819
##########
integration-tests-ex/cases/cluster/Common/dependencies.yaml:
##########
@@ -86,7 +86,37 @@ services:
MYSQL_USER: druid
MYSQL_PASSWORD: diurd
-## TODO: Not yet retested
+ minio:
+ container_name: minio
+ command: server /data --console-address ":9001"
+ networks:
+ druid-it-net:
+ ipv4_address: 172.172.172.5
+ image: minio/minio:latest
+ ports:
+ - '9000:9000'
+ - '9001:9001'
+ volumes:
+ - ${SHARED_DIR}/minio:/data
+ environment:
+ - MINIO_ROOT_USER=${AWS_ACCESS_KEY_ID}
+ - MINIO_ROOT_PASSWORD=${AWS_SECRET_ACCESS_KEY}
+
+ create_minio_buckets:
+ image: minio/mc
+ networks:
+ druid-it-net:
+ ipv4_address: 172.172.172.6
+ depends_on:
+ - minio
+ entrypoint: >
+ /bin/sh -c "
+ /usr/bin/mc alias set s3 http://minio:9000 ${AWS_ACCESS_KEY_ID} ${AWS_SECRET_ACCESS_KEY};
+ /usr/bin/mc mb s3/${DRUID_CLOUD_BUCKET};
+ /usr/bin/mc anonymous set public s3/${DRUID_CLOUD_BUCKET};
+ "
Review Comment:
To prevent race conditions, one of the Druid containers has to depend on this one. That can be done by adding a dependency on, say, the overlord. The tests check that OL is ready, and OL won't be ready (won't start running) until the above is done.
I'm hoping that dependencies indicate only run order and not "OK can't start if create_minio_buckets" isn't running. Please double-check.
##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -42,6 +42,21 @@ on:
required: false
type: string
default: com.mysql.jdbc.Driver
+ DRUID_CLOUD_BUCKET:
+ required: false
+ type: string
+ DRUID_CLOUD_PATH:
+ required: false
+ type: string
+ AWS_REGION:
+ required: false
+ type: string
+ AWS_ACCESS_KEY_ID:
+ required: false
+ type: string
+ AWS_SECRET_ACCESS_KEY:
+ required: false
+ type: string
Review Comment:
Not covered here: if we no longer need env vars for S3, please remove the checks for them in 'it.sh`.
##########
.github/workflows/revised-its.yml:
##########
@@ -36,3 +36,18 @@ jobs:
script: ./it.sh github ${{ matrix.it }}
it: ${{ matrix.it }}
mysql_driver: com.mysql.jdbc.Driver
+
+ s3-deep-storage-minio:
+ uses: ./.github/workflows/reusable-revised-its.yml
+ with:
+ build_jdk: 8
+ runtime_jdk: 11
+ use_indexer: middleManager
+ script: ./it.sh github S3DeepStorage
+ it: S3DeepStorage
+ mysql_driver: com.mysql.jdbc.Driver
+ DRUID_CLOUD_BUCKET: druid-qa
+ DRUID_CLOUD_PATH: aws-${{ github.run_id }}-${{ github.run_attempt }}
+ AWS_REGION: us-east-1
+ AWS_ACCESS_KEY_ID: admin
+ AWS_SECRET_ACCESS_KEY: miniopassword
Review Comment:
Nit: missing newline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhagraw commented on a diff in pull request #13997: Using MinIO to run S3DeepStorage ITs
Posted by "abhagraw (via GitHub)" <gi...@apache.org>.
abhagraw commented on code in PR #13997:
URL: https://github.com/apache/druid/pull/13997#discussion_r1152273552
##########
.github/workflows/reusable-revised-its.yml:
##########
@@ -42,6 +42,21 @@ on:
required: false
type: string
default: com.mysql.jdbc.Driver
+ DRUID_CLOUD_BUCKET:
+ required: false
+ type: string
+ DRUID_CLOUD_PATH:
+ required: false
+ type: string
+ AWS_REGION:
+ required: false
+ type: string
+ AWS_ACCESS_KEY_ID:
+ required: false
+ type: string
+ AWS_SECRET_ACCESS_KEY:
+ required: false
+ type: string
Review Comment:
We still need these vars for S3. It is provided in [revised-its.yml](https://github.com/apache/druid/pull/13997/files/dffa60d450b2858965a9f8196fae789a185c7ef4#diff-70af0d1891a4b15a7fa2c1a0f19c26cfb916b23af84856df56ef7090252dbb38) for `s3-deep-storage-minio`.
`required: false` here refers the value being not mandatory to be provided (only needed by s3 tests), as we use the same `reusable-revised-its.yml` workflow for all ITs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] abhagraw commented on a diff in pull request #13997: Using MinIO to run S3DeepStorage ITs
Posted by "abhagraw (via GitHub)" <gi...@apache.org>.
abhagraw commented on code in PR #13997:
URL: https://github.com/apache/druid/pull/13997#discussion_r1152269953
##########
integration-tests-ex/cases/cluster/Common/dependencies.yaml:
##########
@@ -86,7 +86,37 @@ services:
MYSQL_USER: druid
MYSQL_PASSWORD: diurd
-## TODO: Not yet retested
+ minio:
+ container_name: minio
+ command: server /data --console-address ":9001"
+ networks:
+ druid-it-net:
+ ipv4_address: 172.172.172.5
+ image: minio/minio:latest
+ ports:
+ - '9000:9000'
+ - '9001:9001'
+ volumes:
+ - ${SHARED_DIR}/minio:/data
+ environment:
+ - MINIO_ROOT_USER=${AWS_ACCESS_KEY_ID}
+ - MINIO_ROOT_PASSWORD=${AWS_SECRET_ACCESS_KEY}
+
+ create_minio_buckets:
+ image: minio/mc
+ networks:
+ druid-it-net:
+ ipv4_address: 172.172.172.6
+ depends_on:
+ - minio
+ entrypoint: >
+ /bin/sh -c "
+ /usr/bin/mc alias set s3 http://minio:9000 ${AWS_ACCESS_KEY_ID} ${AWS_SECRET_ACCESS_KEY};
+ /usr/bin/mc mb s3/${DRUID_CLOUD_BUCKET};
+ /usr/bin/mc anonymous set public s3/${DRUID_CLOUD_BUCKET};
+ "
Review Comment:
Added dependency on create_minio_buckets for overlord.
Yeah, here dependencies indicate only run order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] paul-rogers merged pull request #13997: Using MinIO to run S3DeepStorage ITs
Posted by "paul-rogers (via GitHub)" <gi...@apache.org>.
paul-rogers merged PR #13997:
URL: https://github.com/apache/druid/pull/13997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org