[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8971: Fix thread safety issue with java client

[GitBox <gi...@apache.org>]

Jackie-Jiang commented on code in PR #8971:
URL: https://github.com/apache/pinot/pull/8971#discussion_r910925837


##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/ConnectionFactory.java:
##########
@@ -28,7 +28,8 @@
  * Creates connections to Pinot, given various initialization methods.
  */
 public class ConnectionFactory {
-  private static PinotClientTransport _defaultTransport;
+  private static volatile PinotClientTransport _defaultTransport;

Review Comment:
   (minor) This doesn't need to be volatile because it is already guarded by a lock



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org