You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rodrigo93 <gi...@git.apache.org> on 2016/03/13 19:38:55 UTC
[GitHub] cloudstack pull request: Removed Unused Void Class
GitHub user rodrigo93 opened a pull request:
https://github.com/apache/cloudstack/pull/1440
Removed Unused Void Class
Removed the class _Void.java_ from _/cloud-framework-ipc/src/org/apache/cloudstack/framework/async/Void.java_ since the method _public void AsyncMethod(Object realParam,
AsyncCompletionCallback<Void> callback)_ does not exist and it does not seem to be used in another place.
Also, removed an unnecessary comment in
_/cloudstack-framework/ipc/test/org/apache/cloudstack/framework/codestyle/AsyncSampleListenerStyleCaller.java_
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rodrigo93/cloudstack Removed-Unused-Void-class
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1440.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1440
----
commit 01034ea8d642102dadc2fd39d7a01e860cecfa79
Author: Rodrigo <ro...@gmail.com>
Date: 2016-03-13T17:35:51Z
Removed Unused Void Class
Removed the class Void.java from
/cloud-framework-ipc/src/org/apache/cloudstack/framework/async/Void.java
since the method public void AsyncMethod(Object realParam,
AsyncCompletionCallback<Void> callback) does not
exist and it does not seemed to be used in another place.
Also, removed an unnecessary comment in
/cloudstack-framework/ipc/test/org/apache/cloudstack/framework/codestyle/AsyncSampleListenerStyleCaller.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed Unused Void Class
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-216511879
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed Unused Void Class
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-217889598
CI has come back clean. \U0001f44d I will add this to my merge queue. Thx...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed Unused Void Class
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-217771635
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 0
Errors: 0
Duration: 9h 08m 44s
```
**Associated Uploads**
**`/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y:`**
* [dc_entries.obj](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y/dc_entries.obj)
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y/failed_plus_exceptions.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/DeployDataCenter__May_07_2016_07_22_48_R3H25Y/runinfo.txt)
**`/tmp/MarvinLogs/test_network_MSZ3SB:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_network_MSZ3SB/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_network_MSZ3SB/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_network_MSZ3SB/runinfo.txt)
**`/tmp/MarvinLogs/test_vpc_routers_32L4E9:`**
* [failed_plus_exceptions.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_vpc_routers_32L4E9/failed_plus_exceptions.txt)
* [results.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_vpc_routers_32L4E9/results.txt)
* [runinfo.txt](https://objects-east.cloud.ca/v1/e465abe2f9ae4478b9fff416eab61bd9/PR1440/tmp/MarvinLogs/test_vpc_routers_32L4E9/runinfo.txt)
Uploads will be available until `2016-07-09 02:00:00 +0200 CEST`
*Comment created by [`upr comment`](https://github.com/cloudops/upr).*
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed Unused Void Class
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-216225804
LGTM, a CI testing would confirm if PR can be accepted
tag:easypr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed Unused Void Class
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1440
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Removed Unused Void Class
Posted by rodrigo93 <gi...@git.apache.org>.
Github user rodrigo93 commented on the pull request:
https://github.com/apache/cloudstack/pull/1440#issuecomment-220795597
Thanks for the help! =)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---