[GitHub] [ignite-3] kgusakov commented on a diff in pull request #1946: IGNITE-18958 Implement handling of lease grant responses on placement…

["kgusakov (via GitHub)" <gi...@apache.org>]

kgusakov commented on code in PR #1946:
URL: https://github.com/apache/ignite-3/pull/1946#discussion_r1170022645


##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -173,14 +175,19 @@ public void deactivate() {
      * Finds a node that can be the leaseholder.
      *
      * @param assignments Replication group assignment.
+     * @param proposed Proposed consistent id, found out of a lease negotiation. The parameter might be {@code null}.
      * @return Cluster node, or {@code null} if no node in assignments can be the leaseholder.
      */
-    private ClusterNode nextLeaseHolder(Set<Assignment> assignments) {
+    private ClusterNode nextLeaseHolder(Set<Assignment> assignments, @Nullable String proposed) {

Review Comment:
   `proposed` sounds like a boolean flag. Could we rename it to anything like `proposedConsistentId`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org