You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/12/22 15:23:12 UTC
[GitHub] [superset] villebro commented on a diff in pull request #22508: refactor: rename filter_rel_fields to base_related_field_filters
villebro commented on code in PR #22508:
URL: https://github.com/apache/superset/pull/22508#discussion_r1055572274
##########
superset/views/base_api.py:
##########
@@ -195,21 +195,24 @@ class BaseSupersetModelRestApi(ModelRestApi):
}
"""
- related_field_filters: Dict[str, Union[RelatedFieldFilter, str]] = {}
+ base_related_field_filters: Dict[str, BaseFilter] = {}
"""
- Declare the filters for related fields::
+ This is used to specify a base filter for related fields
+ when they are accessed through the '/related/<column_name>' endpoint.
+ When combined with the `related_field_filters` attribute,
+ this filter will be applied in addition to the latest::
Review Comment:
Should we move this comment to `related_field_filters` and say there that the filter is applied in addition (or on top, whichever sounds better) to `base_related_field_filters`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org