[GitHub] [incubator-ratis] juaby commented on pull request #93: RATIS-931. Fixed Add a raft group to all peers currently registered

[GitBox <gi...@apache.org>]

juaby commented on pull request #93:
URL: https://github.com/apache/incubator-ratis/pull/93#issuecomment-641847686


   > Can we rename the member `peers` to be `allKnownPeers` or similar? Something to try to prevent such an error in the future.
   > 
   > What about a test? Did you try to write a unit test to catch this? I think having 4 available workers, create a log, and then look at the raft groups and see that it has 4 members instead of 3 would work.
   
   Sorry, it took so long to reply to you, about the log service, it's okay to verify by documentation (because the members of available workers == the members of new raft groups), but when the working node starts more than 3, when a log is created, the metadata service broadcasts adding the raft group to an unnecessary out-of-raft-group node.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org