You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "GrantPSpencer (via GitHub)" <gi...@apache.org> on 2025/11/20 04:11:59 UTC

[PR] Add default get value for task partition map to prevent NPE [helix]

GrantPSpencer opened a new pull request, #3078:
URL: https://github.com/apache/helix/pull/3078

   ### Issues
   
   - [ ] My PR addresses the following Helix issues and references them in the PR description:
   
   NPE occurring due to null value returned from partitionMap, likely from a disabled instance having task current state causing mismatch in map keys. Current logic makes assumption that `additionPartitionMap.keySet()` == `partitionMap.keySet()`
   
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   Change map.get to .getOrDefault to prevent NPEs
   
   
   ```
   "message": Exception while executing TASK pipeline for cluster <cluster_name_here>. Will not continue to next pipeline,
   "exceptionChain": [
   	{
   		"index": 0,
   		"message": "Cannot invoke \"java.lang.Integer.intValue()\" because the return value of \"java.util.Map.get(Object)\" is null",
   		"stackTrace": [
   			{
   				"index": 0,
   				"call": "fillActiveTaskCount",
   				"columnNumber": null,
   				"fileName": "WorkflowControllerDataProvider.java",
   				"lineNumber": 192,
   				"nativeMethod": false,
   				"source": "org.apache.helix.controller.dataproviders.WorkflowControllerDataProvider"
   			},
   			{
   				"index": 1,
   				"call": "resetActiveTaskCount",
   				"columnNumber": null,
   				"fileName": "WorkflowControllerDataProvider.java",
   				"lineNumber": 178,
   				"nativeMethod": false,
   				"source": "org.apache.helix.controller.dataproviders.WorkflowControllerDataProvider"
   			},
   			{
   				"index": 2,
   				"call": "process",
   				"columnNumber": null,
   				"fileName": "TaskSchedulingStage.java",
   				"lineNumber": 81,
   				"nativeMethod": false,
   				"source": "org.apache.helix.controller.stages.task.TaskSchedulingStage"
   			},
   			{
   				"index": 3,
   				"call": "handle",
   				"columnNumber": null,
   				"fileName": "Pipeline.java",
   				"lineNumber": 75,
   				"nativeMethod": false,
   				"source": "org.apache.helix.controller.pipeline.Pipeline"
   			},
   			{
   				"index": 4,
   				"call": "handleEvent",
   				"columnNumber": null,
   				"fileName": "GenericHelixController.java",
   				"lineNumber": 905,
   				"nativeMethod": false,
   				"source": "org.apache.helix.controller.GenericHelixController"
   			},
   			{
   				"index": 5,
   				"call": "run",
   				"columnNumber": null,
   				"fileName": "GenericHelixController.java",
   				"lineNumber": 1556,
   				"nativeMethod": false,
   				"source": "org.apache.helix.controller.GenericHelixController$ClusterEventProcessor"
   			}
   		],
   		"type": "java.lang.NullPointerException"
   	}
   ],
   "level": ERROR,
   ```
   
   ### Tests
   
   N/A
   
   ### Commits
   
   - My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Code Quality
   
   - My diff has been formatted using helix-style.xml 
   (helix-style-intellij.xml if IntelliJ IDE is used)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [PR] Add default get value for task partition map to prevent NPE [helix]

Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #3078:
URL: https://github.com/apache/helix/pull/3078


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [PR] Add default get value for task partition map to prevent NPE [helix]

Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on PR #3078:
URL: https://github.com/apache/helix/pull/3078#issuecomment-3555755367

   Thanks for the fix. LGTM. 
   Could you please also create an issue explain the bug and link that to this PR?
   
   Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org


Re: [PR] Add default get value for task partition map to prevent NPE [helix]

Posted by "GrantPSpencer (via GitHub)" <gi...@apache.org>.
GrantPSpencer commented on PR #3078:
URL: https://github.com/apache/helix/pull/3078#issuecomment-3559566340

   Pull request approved by: @xyuanlu 
   Commit message: Fix NPE in task pipeline  by adding default get value for partition count maps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org