You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by bennetelli <gi...@git.apache.org> on 2016/10/28 11:47:02 UTC
[GitHub] activemq-artemis pull request #873: ARTEMIS-830 Remove cyclic dependencies
GitHub user bennetelli opened a pull request:
https://github.com/apache/activemq-artemis/pull/873
ARTEMIS-830 Remove cyclic dependencies
Removes cyclic dependencies between classes and packages in the artemis-jdbc-store projetct by moving classes and methods to other locations and reducing the visibility of classes, fields and methods. Solving cyclic dependencies is important to keep the codebase maintainable. Scenarios where "everything uses everything" should be avoided.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #873
----
commit 1d22953bc17815df1716fe79d48497cb180afaf8
Author: Bennet Schulz <ma...@bennet-schulz.de>
Date: 2016-10-28T11:46:00Z
ARTEMIS-830 Remove cyclic dependencies
Removes cyclic dependencies between classes and packages in the artemis-jdbc-store projetct by moving classes and methods to other locations and reducing the visibility of classes, fields and methods. Solving cyclic dependencies is important to keep the codebase maintainable. Scenarios where "everything uses everything" should be avoided.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #873: ARTEMIS-830 Remove cyclic dependencies from art...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/873
Okay.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #873: ARTEMIS-830 Remove cyclic dependencies f...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli closed the pull request at:
https://github.com/apache/activemq-artemis/pull/873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #873: ARTEMIS-830 Remove cyclic dependencies from art...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/873
do you mind closing this PR, it would be superseded by #872 where I already fixed the checkstyle and imported your commit there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #873: ARTEMIS-830 Remove cyclic dependencies f...
Posted by bennetelli <gi...@git.apache.org>.
GitHub user bennetelli reopened a pull request:
https://github.com/apache/activemq-artemis/pull/873
ARTEMIS-830 Remove cyclic dependencies from artemis-jdbc-store
Removes cyclic dependencies between classes and packages in the artemis-jdbc-store projetct by moving classes and methods to other locations and reducing the visibility of classes, fields and methods. Solving cyclic dependencies is important to keep the codebase maintainable. Scenarios where "everything uses everything" should be avoided.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bennetelli/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #873
----
commit 1d22953bc17815df1716fe79d48497cb180afaf8
Author: Bennet Schulz <ma...@bennet-schulz.de>
Date: 2016-10-28T11:46:00Z
ARTEMIS-830 Remove cyclic dependencies
Removes cyclic dependencies between classes and packages in the artemis-jdbc-store projetct by moving classes and methods to other locations and reducing the visibility of classes, fields and methods. Solving cyclic dependencies is important to keep the codebase maintainable. Scenarios where "everything uses everything" should be avoided.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #873: ARTEMIS-830 Remove cyclic dependencies from art...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/873
Can you just close it?
I tried to close it myself and it didn't work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #873: ARTEMIS-830 Remove cyclic dependencies from art...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the issue:
https://github.com/apache/activemq-artemis/pull/873
```
[INFO] --- maven-bundle-plugin:3.0.0:install (default-install) @ artemis-hqclient-protocol ---
[INFO] Starting audit...
/work/apache/six/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/PostgresSequentialSequentialFileDriver.java:23:1: error: Redundant import from the same package - org.apache.activemq.artemis.jdbc.store.file.JDBCSequentialFile.
/work/apache/six/artemis-jdbc-store/src/main/java/org/apache/activemq/artemis/jdbc/store/file/PostgresSequentialSequentialFileDriver.java:24:1: error: Redundant import from the same package - org.apache.activemq.artemis.jdbc.store.file.JDBCSequentialFileFactoryDriver.
Audit done.
[INFO] There are 2 errors reported by Checkstyle 6.11.2 with /work/apache/six/artemis-jdbc-store/../etc/checkstyle.xml ruleset.
[ERROR] src/main/java/org/apache/activemq/artemis/jdbc/store/file/PostgresSequentialSequentialFileDriver.java:[23,1] (imports) RedundantImport: Redundant import from the same package - org.apache.activemq.artemis.jdbc.store.file.JDBCSequentialFile.
[ERROR] src/main/java/org/apache/activemq/artemis/jdbc/store/file/PostgresSequentialSequentialFileDriver.java:[24,1] (imports) RedundantImport: Redundant import from the same package - org.apache.activemq.artemis.jdbc.store.file.JDBCSequentialFileFactoryDriver.
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis issue #873: ARTEMIS-830 Remove cyclic dependencies from art...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli commented on the issue:
https://github.com/apache/activemq-artemis/pull/873
closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #873: ARTEMIS-830 Remove cyclic dependencies f...
Posted by bennetelli <gi...@git.apache.org>.
Github user bennetelli closed the pull request at:
https://github.com/apache/activemq-artemis/pull/873
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---