You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/07 13:11:40 UTC

[GitHub] [skywalking-docker] wu-sheng commented on a change in pull request #24: Merge Docker images for ES 6 / 7 into one

wu-sheng commented on a change in pull request #24:
URL: https://github.com/apache/skywalking-docker/pull/24#discussion_r703496773



##########
File path: base/Dockerfile
##########
@@ -13,22 +13,14 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
-ARG tag
 
 FROM adoptopenjdk/openjdk11:alpine AS base
 ARG version
 RUN echo "Building Apache SkyWalking ${version}"
 ENV SKYWALKING_VERSION=${version}
-
-FROM base AS es6
-RUN echo "This is the stage that build the es6 image"
 ENV SKYWALKING_TGZ=apache-skywalking-apm-${SKYWALKING_VERSION}.tar.gz
 
-FROM base AS es7
-RUN echo "This is the stage that build the es7 image"
-ENV SKYWALKING_TGZ=apache-skywalking-apm-es7-${SKYWALKING_VERSION}.tar.gz
-
-FROM ${tag} AS build
+FROM base AS build

Review comment:
       A tip, with these changes are not backward compatible, we need another archive to keep all these documentation and scripts, right?
   We don't do official release for this repo. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org