[GitHub] [airflow] abhishekray07 commented on a change in pull request #5277: [AIRFLOW-4510] Don't mutate default_args during DAG initialization

[GitBox <gi...@apache.org>]

abhishekray07 commented on a change in pull request #5277: [AIRFLOW-4510] Don't mutate default_args during DAG initialization
URL: https://github.com/apache/airflow/pull/5277#discussion_r299134638
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -195,7 +195,7 @@ def __init__(
     ):
         self.user_defined_macros = user_defined_macros
         self.user_defined_filters = user_defined_filters
-        self.default_args = default_args or {}
+        self.default_args = dict(default_args or {})
 
 Review comment:
   Yeah, I think we can do a deepcopy instead. Will make that change!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services