You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/05/28 02:49:38 UTC

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1275: Fix ForceAppendTsFileWriter

HTHou commented on a change in pull request #1275:
URL: https://github.com/apache/incubator-iotdb/pull/1275#discussion_r431552580



##########
File path: tsfile/src/test/java/org/apache/iotdb/tsfile/write/writer/ForceAppendTsFileWriterTest.java
##########
@@ -56,6 +65,38 @@ public void test() throws Exception {
     writer.close();
     ForceAppendTsFileWriter fwriter = new ForceAppendTsFileWriter(file);
     assertEquals(firstMetadataPosition, fwriter.getTruncatePosition());
+
+    // write more data into this TsFile
+    writer = new TsFileWriter(fwriter);
+    writer.registerTimeseries(new Path("d1.s1"),
+        new MeasurementSchema("s1", TSDataType.FLOAT, TSEncoding.RLE));
+    writer.registerTimeseries(new Path("d1.s2"),
+        new MeasurementSchema("s2", TSDataType.FLOAT, TSEncoding.RLE));

Review comment:
       Please note, since we aren't able to recover schema from metadata, I register the timeseries again here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org