You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2023/02/26 20:07:13 UTC

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19541


Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil.
......................................................................

IMPALA-11479: Add Java unit tests for IcebergUtil.

This does not test all of IcebergUtil, but it is a start.
Tidy up some IcebergUtil code and fix a few spelling mistakes.

Change-Id: I8c1162ae87a228bd8fe057bbd2cf47dcde432e15
---
M fe/src/main/java/org/apache/impala/common/TransactionKeepalive.java
M fe/src/main/java/org/apache/impala/util/IcebergUtil.java
M fe/src/test/java/org/apache/impala/catalog/local/LocalCatalogTest.java
A fe/src/test/java/org/apache/impala/util/IcebergUtilTest.java
4 files changed, 460 insertions(+), 56 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/41/19541/1
-- 
To view, visit http://gerrit.cloudera.org:8080/19541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8c1162ae87a228bd8fe057bbd2cf47dcde432e15
Gerrit-Change-Number: 19541
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/19541 )

Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil.
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/19541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I8c1162ae87a228bd8fe057bbd2cf47dcde432e15
Gerrit-Change-Number: 19541
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>

[Impala-ASF-CR] IMPALA-11479: Add Java unit tests for IcebergUtil.

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19541 )

Change subject: IMPALA-11479: Add Java unit tests for IcebergUtil.
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/12447/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/19541
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8c1162ae87a228bd8fe057bbd2cf47dcde432e15
Gerrit-Change-Number: 19541
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sun, 26 Feb 2023 20:27:52 +0000
Gerrit-HasComments: No