[GitHub] [incubator-pekko] Claudenw commented on a diff in pull request #44: stream: fix regression in JsonFraming

["Claudenw (via GitHub)" <gi...@apache.org>]

Claudenw commented on code in PR #44:
URL: https://github.com/apache/incubator-pekko/pull/44#discussion_r1201906618


##########
stream/src/main/scala/org/apache/pekko/stream/impl/JsonObjectParser.scala:
##########
@@ -117,21 +117,22 @@ import pekko.util.ByteString
     val bufSize = buffer.length
 
     skipToNextObject(bufSize)
+    val maxObjectLengthIndex = if (pos + maximumObjectLength < 0) Int.MaxValue else pos + maximumObjectLength

Review Comment:
   Do you have a check for "huge objects"?  Perhaps placing an upper limit on the object size is a good start until a complete solution can be discovered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org