You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/03/20 03:52:44 UTC

[GitHub] mistercrunch commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics

mistercrunch commented on a change in pull request #4646: Allowing limit ordering by post-aggregation metrics
URL: https://github.com/apache/incubator-superset/pull/4646#discussion_r175648639
 
 

 ##########
 File path: superset/connectors/druid/models.py
 ##########
 @@ -925,7 +925,18 @@ def metrics_and_post_aggs(metrics, metrics_dict):
             visited_postaggs.add(postagg_name)
             DruidDatasource.resolve_postagg(
 
 Review comment:
   same as comment bellow, should be `@staticmethod` and `cls.resolve_postagg `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services