[GitHub] [incubator-uniffle] zuston commented on a diff in pull request #64: Log enhancement: return error message when getting assignment servers and log exception when initializing

[GitBox <gi...@apache.org>]

zuston commented on code in PR #64:
URL: https://github.com/apache/incubator-uniffle/pull/64#discussion_r927252594


##########
coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java:
##########
@@ -49,8 +49,12 @@ public class CoordinatorServer {
 
   public CoordinatorServer(CoordinatorConf coordinatorConf) throws Exception {
     this.coordinatorConf = coordinatorConf;
-    initialization();
-
+    try {

Review Comment:
   I hope all initializing exception message can be recorded into log files. Sometimes due to abnormal configuration,  server or coordinator will exit directly no any log recorded, which is hard to debug. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org