You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/09/15 09:02:00 UTC

[GitHub] [camel] essobedo opened a new pull request, #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

essobedo opened a new pull request, #8381:
URL: https://github.com/apache/camel/pull/8381

   Fix for https://issues.apache.org/jira/browse/CAMEL-17197
   
   ## Motivation
   
   When running test IT tests some warnings appear in the console, we would like to get rid of them.
   
   ## Modifications
   
   * No more set the mapping type in the requests since it is [deprecated](https://www.elastic.co/guide/en/elasticsearch/reference/7.17/removal-of-types.html)
   * Re-add the test `ElasticsearchSizeLimitIT` as it passes (not related to the initial issue)
   * Clean up the code by removing existing warnings raised by IntelliJ. (not related to the initial issue)
   
   ## Result
   
   No more warnings in the log:
   
   ```
   [INFO] Running org.apache.camel.component.elasticsearch.integration.ElasticsearchIndexIT
   [INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.323 s - in org.apache.camel.component.elasticsearch.integration.ElasticsearchIndexIT
   [INFO] Running org.apache.camel.component.elasticsearch.integration.ElasticsearchClusterIndexIT
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.788 s - in org.apache.camel.component.elasticsearch.integration.ElasticsearchClusterIndexIT
   [INFO] Running org.apache.camel.component.elasticsearch.integration.ElasticsearchBulkIT
   [INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.935 s - in org.apache.camel.component.elasticsearch.integration.ElasticsearchBulkIT
   [INFO] Running org.apache.camel.component.elasticsearch.integration.ElasticsearchSizeLimitIT
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.515 s - in org.apache.camel.component.elasticsearch.integration.ElasticsearchSizeLimitIT
   [INFO] Running org.apache.camel.component.elasticsearch.integration.ElasticsearchPingIT
   [INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.191 s - in org.apache.camel.component.elasticsearch.integration.ElasticsearchPingIT
   [INFO] Running org.apache.camel.component.elasticsearch.integration.ElasticsearchGetSearchDeleteExistsUpdateIT
   [INFO] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.271 s - in org.apache.camel.component.elasticsearch.integration.ElasticsearchGetSearchDeleteExistsUpdateIT
   [INFO] Running org.apache.camel.component.elasticsearch.integration.ElasticsearchScrollSearchIT
   [INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 13.558 s - in org.apache.camel.component.elasticsearch.integration.ElasticsearchScrollSearchIT
   [INFO] 
   [INFO] Results:
   [INFO] 
   [INFO] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo merged pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
essobedo merged PR #8381:
URL: https://github.com/apache/camel/pull/8381


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247825939

   There is also [Elasticsearch Java API Client [8.4]](https://www.elastic.co/guide/en/elasticsearch/client/java-api-client/current/index.html) which also has  [the correct license](https://search.maven.org/artifact/co.elastic.clients/elasticsearch-java/8.4.1/jar) (Apache v2) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247816278

   @oscerd this client seems to have the correct license (Apache v2) https://search.maven.org/artifact/org.elasticsearch.client/elasticsearch-rest-client/8.4.1/jar


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247835080

   There is a ticket for it [CAMEL-17780](https://issues.apache.org/jira/browse/CAMEL-17780).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] oscerd commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247890513

   Yes, I didn't find the time to start to work on it. But I believe it needs to be done 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] essobedo commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
essobedo commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247828885

   It is actually the client that replaces the [Java High Level REST Client](https://github.com/elastic/elasticsearch/edit/7.17/docs/java-rest/high-level/index.asciidoc)
   I quote:
   ```
   Deprecated in 7.15.0.
   The High Level REST Client is deprecated in favour of the [Java API Client](https://www.elastic.co/guide/en/elasticsearch/client/java-api-client/7.17/index.html).
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] oscerd commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247819631

   Yes, but some of the features of the high level client won't be available 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247811089

   :warning: This PR changes Camel components and will be tested automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] oscerd commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
oscerd commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247830605

   We do need to switch at some point


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [camel] github-actions[bot] commented on pull request #8381: CAMEL-17197: camel-elasticsearch - Avoid using deprecated APIs

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #8381:
URL: https://github.com/apache/camel/pull/8381#issuecomment-1247887145

   :heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org