You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2022/08/01 07:12:04 UTC
[GitHub] [incubator-pegasus] foreverneverer opened a new pull request, #1088: fix: revert zk c client to 3.4.10 for compatibility
foreverneverer opened a new pull request, #1088:
URL: https://github.com/apache/incubator-pegasus/pull/1088
### What problem does this PR solve? <!--add issue link with summary if exists-->
### What is changed and how does it work?
### Checklist <!--REMOVE the items that are not applicable-->
##### Tests <!-- At least one of them must be included. -->
- Unit test
- Integration test
- Manual test (add detailed scripts or steps below)
- No code
##### Code changes
- Has exported function/method change
- Has exported variable/fields change
- Has interface methods change
- Has persistent data change
##### Side effects
- Possible performance regression
- Increased code complexity
- Breaking backward compatibility
##### Related changes
- Need to cherry-pick to the release branch
- Need to update the documentation
- Need to be included in the release note
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer closed pull request #1088: fix: revert zk c client to 3.4.10 for compatibility
Posted by GitBox <gi...@apache.org>.
foreverneverer closed pull request #1088: fix: revert zk c client to 3.4.10 for compatibility
URL: https://github.com/apache/incubator-pegasus/pull/1088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1088: fix: revert zk c client to 3.4.10 for compatibility
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1088:
URL: https://github.com/apache/incubator-pegasus/pull/1088#issuecomment-1202951213
> > Let’s disccus clearly before merging, thanks!
>
> OK, I hope it can be determined as soon as possible, because the release of 2.4 has been postponed for a long time. If it can't be solved, I hope this problem can be reconsidered after 2.4
How about release 2.4 without this patch, and you can release an internal release or a other type of spcial release with this patch. In SensorsData we have tested with zk client 3.7.0 with zk server kerberos enabled and disabled, all works well as expected. And you guys also tested that in some product envs, I guess there may be some DNS issue in you mentioned "tjwq-test" env :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on pull request #1088: fix: revert zk c client to 3.4.10 for compatibility
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on PR #1088:
URL: https://github.com/apache/incubator-pegasus/pull/1088#issuecomment-1212813058
LGTM to merge it to branch 2.4.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer merged pull request #1088: fix: revert zk c client to 3.4.10 for compatibility
Posted by GitBox <gi...@apache.org>.
foreverneverer merged PR #1088:
URL: https://github.com/apache/incubator-pegasus/pull/1088
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] foreverneverer commented on pull request #1088: fix: revert zk c client to 3.4.10 for compatibility
Posted by GitBox <gi...@apache.org>.
foreverneverer commented on PR #1088:
URL: https://github.com/apache/incubator-pegasus/pull/1088#issuecomment-1201983688
> Let’s disccus clearly before merging, thanks!
OK, I hope it can be determined as soon as possible, because the release of 2.4 has been postponed for a long time. If it can't be solved, I hope this problem can be reconsidered after 2.4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org