[GitHub] [apisix] membphis commented on a change in pull request #3013: fix: enable ssl as default, using placeholder certificate

[GitBox <gi...@apache.org>]

membphis commented on a change in pull request #3013:
URL: https://github.com/apache/apisix/pull/3013#discussion_r540245672



##########
File path: conf/config-default.yaml
##########
@@ -101,15 +101,14 @@ apisix:
   dns_resolver_valid: 30          # valid time for dns result 30 seconds
   resolver_timeout: 5             # resolver timeout
   ssl:
-    enable: false                 # ssl is disabled by default
-                                  # enable it to use your own cert and key
+    enable: true
     enable_http2: true
     listen_port: 9443
     # ssl_trusted_certificate: /path/to/ca-cert # Specifies a file path with trusted CA certificates in the PEM format
                                                 # used to verify the certificate when APISIX needs to do SSL/TLS handshaking
                                                 # with external services (e.g. etcd)
-    # ssl_cert: /path/to/ssl_cert
-    # ssl_cert_key: /path/to/ssl_cert_key
+    ssl_cert: "cert/ssl_PLACE_HOLDER.crt"

Review comment:
       I think we can remove this option, the user does not need to care about it

##########
File path: conf/config-default.yaml
##########
@@ -101,15 +101,14 @@ apisix:
   dns_resolver_valid: 30          # valid time for dns result 30 seconds
   resolver_timeout: 5             # resolver timeout
   ssl:
-    enable: false                 # ssl is disabled by default
-                                  # enable it to use your own cert and key
+    enable: true
     enable_http2: true
     listen_port: 9443
     # ssl_trusted_certificate: /path/to/ca-cert # Specifies a file path with trusted CA certificates in the PEM format
                                                 # used to verify the certificate when APISIX needs to do SSL/TLS handshaking
                                                 # with external services (e.g. etcd)
-    # ssl_cert: /path/to/ssl_cert
-    # ssl_cert_key: /path/to/ssl_cert_key
+    ssl_cert: "cert/ssl_PLACE_HOLDER.crt"
+    ssl_cert_key: "cert/ssl_PLACE_HOLDER.key"

Review comment:
       ditto




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org