You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "damccorm (via GitHub)" <gi...@apache.org> on 2023/04/07 17:48:42 UTC
[GitHub] [beam] damccorm opened a new pull request, #26178: Force users to always specify a tag when creating a MultiProcessShared object (breaking)
damccorm opened a new pull request, #26178:
URL: https://github.com/apache/beam/pull/26178
Right now, we don't require a value for the mps tag. This means that the default behavior (if a user doesn't know what they're doing) is to not actually share the object across processes; instead each process will create an object for that process.
One downside of this is that this change does make it harder to have a single process that proxies all requests to a separate process (which is the current behavior if you specify no tag and `alwaysProxy=true`). If a user really wants that use case, they can do something like `abc=MultiProcessShared(<constructor>, tag=uuid.uuid().hex, alwaysProxy=true)` to get the same behavior. I think that will be a much rarer use case though.
This change is intentionally breaking because if anyone is currently using this feature they're probably actually intending to share the object. Plus this whole thing was sorta busted in the mainline case anyways (see https://github.com/apache/beam/pull/26172)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26178: Force users to always specify a tag when creating a MultiProcessShared object (breaking)
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26178:
URL: https://github.com/apache/beam/pull/26178#issuecomment-1512111896
R: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #26178: Force users to always specify a tag when creating a MultiProcessShared object (breaking)
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #26178:
URL: https://github.com/apache/beam/pull/26178
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26178: Force users to always specify a tag when creating a MultiProcessShared object (breaking)
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26178:
URL: https://github.com/apache/beam/pull/26178#issuecomment-1500518836
Looks like tests are going to fail until we have https://github.com/apache/beam/actions/runs/4640195969/jobs/8211875305?pr=26178 (which is good evidence that we need it 😃)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26178: Force users to always specify a tag when creating a MultiProcessShared object (breaking)
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26178:
URL: https://github.com/apache/beam/pull/26178#issuecomment-1513231129
Note that merging in master with #26172 fixed the previously failing test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26178: Force users to always specify a tag when creating a MultiProcessShared object (breaking)
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26178:
URL: https://github.com/apache/beam/pull/26178#issuecomment-1500519812
## [Codecov](https://codecov.io/gh/apache/beam/pull/26178?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26178](https://codecov.io/gh/apache/beam/pull/26178?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a27e752) into [master](https://codecov.io/gh/apache/beam/commit/87db1ae2c04e8589590e6cf8784b5d6d36878241?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87db1ae) will **decrease** coverage by `0.01%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #26178 +/- ##
==========================================
- Coverage 71.17% 71.17% -0.01%
==========================================
Files 787 787
Lines 103294 103310 +16
==========================================
+ Hits 73523 73528 +5
- Misses 28283 28294 +11
Partials 1488 1488
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `79.85% <100.00%> (-0.02%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/beam/pull/26178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...s/python/apache\_beam/utils/multi\_process\_shared.py](https://codecov.io/gh/apache/beam/pull/26178?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvbXVsdGlfcHJvY2Vzc19zaGFyZWQucHk=) | `97.34% <100.00%> (-0.03%)` | :arrow_down: |
... and [8 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26178/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26178: Force users to always specify a tag when creating a MultiProcessShared object (breaking)
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26178:
URL: https://github.com/apache/beam/pull/26178#issuecomment-1512113040
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org