You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/07 16:45:39 UTC

[GitHub] [arrow-rs] tustvold opened a new issue, #1812: Rename ArrayData::validate_dictionary_offset

tustvold opened a new issue, #1812:
URL: https://github.com/apache/arrow-rs/issues/1812

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   `ArrayData::validate_dictionary_offset` no longer just validates dictionary offsets and instead verifies array offsets, decimal precision, etc..
   
   **Describe the solution you'd like**
   
   I would like to propose renaming `ArrayData::validate_dictionary_offset` to `ArrayData::validate_values`. Potentially first deprecating the old method.
   
   **Describe alternatives you've considered**
   
   We could not do this.
   
   **Additional context**
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #1812: Rename ArrayData::validate_dictionary_offset

Posted by GitBox <gi...@apache.org>.
tustvold closed issue #1812: Rename ArrayData::validate_dictionary_offset
URL: https://github.com/apache/arrow-rs/issues/1812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] viirya commented on issue #1812: Rename ArrayData::validate_dictionary_offset

Posted by GitBox <gi...@apache.org>.
viirya commented on issue #1812:
URL: https://github.com/apache/arrow-rs/issues/1812#issuecomment-1148973529

   +1 for this. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org