You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "virgil hong (JIRA)" <ji...@apache.org> on 2012/06/18 07:44:42 UTC
[jira] [Created] (TAP5-1957) The setupRender is not always trigger
after upgrade to 5.3.2
virgil hong created TAP5-1957:
---------------------------------
Summary: The setupRender is not always trigger after upgrade to 5.3.2
Key: TAP5-1957
URL: https://issues.apache.org/jira/browse/TAP5-1957
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.3.2
Reporter: virgil hong
When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
the strange thing is some pages ok, some pages bad....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1957) setupRender methods are not always
invoked
Posted by "virgil hong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
virgil hong updated TAP5-1957:
------------------------------
Description:
When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
the strange thing is some pages ok, some pages bad....
OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
The Overide method like this:
private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
{
return F.flow(assetPaths).map(new Mapper<String, Asset>()
{
public Asset map(String assetPath)
{
if (assetPath.indexOf(":")>0) {
return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
//return assetSource.getExpandedAsset(assetPath);
}
return assetSource.getAsset(baseResource, assetPath, locale);
}
}).toArray(Asset.class);
}
======================
so, I guess is setupRender some thing not correct perform after the @Import work
was:
When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
the strange thing is some pages ok, some pages bad....
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
> OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
> The Overide method like this:
> private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
> {
> return F.flow(assetPaths).map(new Mapper<String, Asset>()
> {
> public Asset map(String assetPath)
> {
> if (assetPath.indexOf(":")>0) {
> return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
> //return assetSource.getExpandedAsset(assetPath);
> }
> return assetSource.getAsset(baseResource, assetPath, locale);
> }
> }).toArray(Asset.class);
> }
> ======================
> so, I guess is setupRender some thing not correct perform after the @Import work
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1957) setupRender methods are not always
invoked
Posted by "virgil hong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400246#comment-13400246 ]
virgil hong commented on TAP5-1957:
-----------------------------------
yes, it's OK, thanks!
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
> OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
> The Overide method like this:
> private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
> {
> return F.flow(assetPaths).map(new Mapper<String, Asset>()
> {
> public Asset map(String assetPath)
> {
> if (assetPath.indexOf(":")>0) {
> return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
> //return assetSource.getExpandedAsset(assetPath);
> }
> return assetSource.getAsset(baseResource, assetPath, locale);
> }
> }).toArray(Asset.class);
> }
> ======================
> so, I guess is setupRender some thing not correct perform after the @Import work
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1957) setupRender methods are not always
invoked
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1957.
--------------------------------------
Resolution: Invalid
There is a relationship between ImportWorker and RenderPhaseWorker; if you fail to keep them in the correct order, then RenderPhaseWorker may be impacted as you describe.
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
> OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
> The Overide method like this:
> private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
> {
> return F.flow(assetPaths).map(new Mapper<String, Asset>()
> {
> public Asset map(String assetPath)
> {
> if (assetPath.indexOf(":")>0) {
> return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
> //return assetSource.getExpandedAsset(assetPath);
> }
> return assetSource.getAsset(baseResource, assetPath, locale);
> }
> }).toArray(Asset.class);
> }
> ======================
> so, I guess is setupRender some thing not correct perform after the @Import work
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1957) setupRender methods are not always
invoked
Posted by "virgil hong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
virgil hong updated TAP5-1957:
------------------------------
Description:
When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
the strange thing is some pages ok, some pages bad....
OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
The Overide method like this:
private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
{
return F.flow(assetPaths).map(new Mapper<String, Asset>()
{
public Asset map(String assetPath)
{
if (assetPath.indexOf(":")>0) {
return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
//return assetSource.getExpandedAsset(assetPath);
}
return assetSource.getAsset(baseResource, assetPath, locale);
}
}).toArray(Asset.class);
}
======================
so, I guess is setupRender some thing not correct perform after the @Import work
was:
When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
the strange thing is some pages ok, some pages bad....
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
> OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
> The Overide method like this:
> private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
> {
> return F.flow(assetPaths).map(new Mapper<String, Asset>()
> {
> public Asset map(String assetPath)
> {
> if (assetPath.indexOf(":")>0) {
> return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
> //return assetSource.getExpandedAsset(assetPath);
> }
> return assetSource.getAsset(baseResource, assetPath, locale);
> }
> }).toArray(Asset.class);
> }
> ======================
> so, I guess is setupRender some thing not correct perform after the @Import work
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1957) setupRender methods are not always
invoked
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1957:
---------------------------------------
Labels: (was: setupRender)
Summary: setupRender methods are not always invoked (was: The setupRender is not always trigger after upgrade to 5.3.2)
This will likely be closed as "not reproducable" unless you can provide a test case, or at least, sample code on which the problem has been observed. Although the code for class transformation was rewritten in 5.3, that code is backed up by hundreds of tests, and I personally have done upgrades from Tapestry 5.2 to 5.3 on some massive sites without encountering the problem you describe. That doesn't rule it out, but given that I can't think of scenario that would allow the behavior you are seeing, my first expectation is that something outside of Tapestry is causing the problem, and that raises the bar for proving there's a problem, and not some coding error in your own code.
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1957) setupRender methods are not always
invoked
Posted by "virgil hong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13400246#comment-13400246 ]
virgil hong commented on TAP5-1957:
-----------------------------------
yes, it's OK, thanks!
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
> OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
> The Overide method like this:
> private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
> {
> return F.flow(assetPaths).map(new Mapper<String, Asset>()
> {
> public Asset map(String assetPath)
> {
> if (assetPath.indexOf(":")>0) {
> return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
> //return assetSource.getExpandedAsset(assetPath);
> }
> return assetSource.getAsset(baseResource, assetPath, locale);
> }
> }).toArray(Asset.class);
> }
> ======================
> so, I guess is setupRender some thing not correct perform after the @Import work
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1957) setupRender methods are not always
invoked
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship updated TAP5-1957:
---------------------------------------
Labels: (was: setupRender)
Summary: setupRender methods are not always invoked (was: The setupRender is not always trigger after upgrade to 5.3.2)
This will likely be closed as "not reproducable" unless you can provide a test case, or at least, sample code on which the problem has been observed. Although the code for class transformation was rewritten in 5.3, that code is backed up by hundreds of tests, and I personally have done upgrades from Tapestry 5.2 to 5.3 on some massive sites without encountering the problem you describe. That doesn't rule it out, but given that I can't think of scenario that would allow the behavior you are seeing, my first expectation is that something outside of Tapestry is causing the problem, and that raises the bar for proving there's a problem, and not some coding error in your own code.
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1957) setupRender methods are not always
invoked
Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1957.
--------------------------------------
Resolution: Invalid
There is a relationship between ImportWorker and RenderPhaseWorker; if you fail to keep them in the correct order, then RenderPhaseWorker may be impacted as you describe.
> setupRender methods are not always invoked
> ------------------------------------------
>
> Key: TAP5-1957
> URL: https://issues.apache.org/jira/browse/TAP5-1957
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.3.2
> Reporter: virgil hong
>
> When after upgrade to 5.3.2, my project some pages not alwarys trigger the SetupRender method, but after restart the Jetty, then it's OK, it's not stable, or sometime unlucky restart the server repeat, it's also exists the problem, I have to change the setupRender method to onAcitvate;
> the strange thing is some pages ok, some pages bad....
> OK, Tks Howard reply, I check my code found the question because of overwrite @ImportWork, for I can get the exteral resource without localized;
> The Overide method like this:
> private Asset[] convertPathsToAssetArray(final Resource baseResource, final Locale locale, String[] assetPaths)
> {
> return F.flow(assetPaths).map(new Mapper<String, Asset>()
> {
> public Asset map(String assetPath)
> {
> if (assetPath.indexOf(":")>0) {
> return assetSource.getUnlocalizedAsset(symbolSource.expandSymbols(assetPath));
> //return assetSource.getExpandedAsset(assetPath);
> }
> return assetSource.getAsset(baseResource, assetPath, locale);
> }
> }).toArray(Asset.class);
> }
> ======================
> so, I guess is setupRender some thing not correct perform after the @Import work
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira