[GitHub] keith-turner opened a new issue #938: Make transaction info cache size configurable.

[gi...@git.apache.org]

keith-turner opened a new issue #938: Make transaction info cache size configurable.
URL: https://github.com/apache/fluo/issues/938
 
 
   Fluo caches information about failed transactions.  This helps speed up the case where multiple row/cols were modified by a failed transaction.  Currently this cache size is hard coded.  Also the timeout of the cache is hard coded.  It would be nice change these to impl properties.  Impl properties are ones that are not part of the public API and are tightly coupled to an internal implementation that could change at any moment.
   
   The cache is created in the [ TxInfoCache constructor](https://github.com/apache/fluo/blob/rel/fluo-1.1.0-incubating/modules/core/src/main/java/org/apache/fluo/core/impl/TxInfoCache.java#L40).  In this constructor it would be nice to do something like :
   
   ```java
   TxInfoCache(Environment env) {
      long cahceSize = FluoConfigurationImpl.getTxInfoCacheSize(env.getConfiguration());
      long timeOut = FluoConfigurationImpl.getTxInfoCacheTimeout(env.getConfiguration());
      //construct cache using vals above...not sure if should be long or int.. depends on type that cache takes
   }
   ```
   
   The methods above would have to be added to [FluoConfigurationImpl](https://github.com/apache/fluo/blob/rel/fluo-1.1.0-incubating/modules/core/src/main/java/org/apache/fluo/core/impl/FluoConfigurationImpl.java).  These methods should probably follow the pattern of `FluoConfigurationImpl.getTxCommitMemory()`
   
   Possible property names are `fluo.impl.tx.failed.cache.size.mb` and `fluo.impl.tx.failed.cache.expireTime`
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services