You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@groovy.apache.org by su...@apache.org on 2021/08/07 19:56:42 UTC
[groovy] branch master updated: Trivial refactoring: extract
`Deprecated` type constant
This is an automated email from the ASF dual-hosted git repository.
sunlan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/groovy.git
The following commit(s) were added to refs/heads/master by this push:
new 2123572 Trivial refactoring: extract `Deprecated` type constant
2123572 is described below
commit 21235726a03b1b77e040d4e24dd9553586988fbb
Author: Daniel Sun <su...@apache.org>
AuthorDate: Sun Aug 8 03:56:28 2021 +0800
Trivial refactoring: extract `Deprecated` type constant
---
src/main/java/org/codehaus/groovy/ast/ClassHelper.java | 1 +
.../java/org/codehaus/groovy/transform/DelegateASTTransformation.java | 2 +-
.../org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java | 3 ++-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/main/java/org/codehaus/groovy/ast/ClassHelper.java b/src/main/java/org/codehaus/groovy/ast/ClassHelper.java
index dbf8929..7af1576 100644
--- a/src/main/java/org/codehaus/groovy/ast/ClassHelper.java
+++ b/src/main/java/org/codehaus/groovy/ast/ClassHelper.java
@@ -142,6 +142,7 @@ public class ClassHelper {
SERIALIZEDLAMBDA_TYPE = makeCached(SerializedLambda.class),
SEALED_TYPE = makeCached(Sealed.class),
OVERRIDE_TYPE = makeCached(Override.class),
+ DEPRECATED_TYPE = makeCached(Deprecated.class),
// uncached constants
MAP_TYPE = makeWithoutCaching(Map.class),
diff --git a/src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java b/src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java
index 1895760..af03683 100644
--- a/src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java
+++ b/src/main/java/org/codehaus/groovy/transform/DelegateASTTransformation.java
@@ -52,6 +52,7 @@ import java.util.stream.Collectors;
import static java.util.stream.Collectors.toSet;
import static org.apache.groovy.ast.tools.ClassNodeUtils.addGeneratedMethod;
import static org.apache.groovy.util.BeanUtils.capitalize;
+import static org.codehaus.groovy.ast.ClassHelper.DEPRECATED_TYPE;
import static org.codehaus.groovy.ast.ClassHelper.isGroovyObjectType;
import static org.codehaus.groovy.ast.ClassHelper.isObjectType;
import static org.codehaus.groovy.ast.ClassHelper.isPrimitiveBoolean;
@@ -90,7 +91,6 @@ public class DelegateASTTransformation extends AbstractASTTransformation {
private static final Class<?> MY_CLASS = Delegate.class;
private static final ClassNode MY_TYPE = make(MY_CLASS);
private static final String MY_TYPE_NAME = "@" + MY_TYPE.getNameWithoutPackage();
- private static final ClassNode DEPRECATED_TYPE = make(Deprecated.class);
private static final ClassNode LAZY_TYPE = make(Lazy.class);
private static final String MEMBER_DEPRECATED = "deprecated";
diff --git a/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java b/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java
index 1e8587d..818c184 100644
--- a/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java
+++ b/src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java
@@ -81,6 +81,7 @@ import static org.codehaus.groovy.ast.ClassHelper.Byte_TYPE;
import static org.codehaus.groovy.ast.ClassHelper.CLOSURE_TYPE;
import static org.codehaus.groovy.ast.ClassHelper.COLLECTION_TYPE;
import static org.codehaus.groovy.ast.ClassHelper.Character_TYPE;
+import static org.codehaus.groovy.ast.ClassHelper.DEPRECATED_TYPE;
import static org.codehaus.groovy.ast.ClassHelper.Double_TYPE;
import static org.codehaus.groovy.ast.ClassHelper.Enum_Type;
import static org.codehaus.groovy.ast.ClassHelper.Float_TYPE;
@@ -176,7 +177,7 @@ public abstract class StaticTypeCheckingSupport {
protected static final ClassNode ArrayList_TYPE = makeWithoutCaching(ArrayList.class);
protected static final ClassNode BaseStream_TYPE = makeWithoutCaching(BaseStream.class);
protected static final ClassNode Collection_TYPE = COLLECTION_TYPE; // TODO: deprecate?
- protected static final ClassNode Deprecated_TYPE = makeWithoutCaching(Deprecated.class);
+ protected static final ClassNode Deprecated_TYPE = DEPRECATED_TYPE;
protected static final ClassNode LinkedHashMap_TYPE = makeWithoutCaching(LinkedHashMap.class);
protected static final ClassNode LinkedHashSet_TYPE = makeWithoutCaching(LinkedHashSet.class);