You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/27 21:04:43 UTC
Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able to
register template
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12136/
-----------------------------------------------------------
Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek.
Bugs: CLOUDSTACK-3245
Repository: cloudstack-git
Description
-------
CLOUDSTACK-3245: non admin user not able to register template
During registering template Admin only API parameter is set defaulted to false in the API layer if it is not set which causing user to fail registering template.
Diffs
-----
api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 13bd5da
server/src/com/cloud/template/TemplateAdapterBase.java 7835680
Diff: https://reviews.apache.org/r/12136/diff/
Testing
-------
Thanks,
Harikrishna Patnala
Re: Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able
to register template
Posted by Alena Prokharchyk <al...@citrix.com>.
> On June 27, 2013, 9:10 p.m., Alena Prokharchyk wrote:
> > Ship It!
Pushed to master branch with commit c8692f2e4a9760a58dbf457bf128fa484a491d0d
- Alena
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12136/#review22488
-----------------------------------------------------------
On June 27, 2013, 7:04 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12136/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 7:04 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3245
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3245: non admin user not able to register template
>
> During registering template Admin only API parameter is set defaulted to false in the API layer if it is not set which causing user to fail registering template.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 13bd5da
> server/src/com/cloud/template/TemplateAdapterBase.java 7835680
>
> Diff: https://reviews.apache.org/r/12136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able
to register template
Posted by Alena Prokharchyk <al...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12136/#review22488
-----------------------------------------------------------
Ship it!
Ship It!
- Alena Prokharchyk
On June 27, 2013, 7:04 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12136/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 7:04 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3245
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3245: non admin user not able to register template
>
> During registering template Admin only API parameter is set defaulted to false in the API layer if it is not set which causing user to fail registering template.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 13bd5da
> server/src/com/cloud/template/TemplateAdapterBase.java 7835680
>
> Diff: https://reviews.apache.org/r/12136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able
to register template
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12136/#review22504
-----------------------------------------------------------
Commit 11a28aae455ba070a8afa105a51a758a78762f9e in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=11a28aa ]
CLOUDSTACK-3245: non admin user not able to register template
Signed-off-by: Jayapal <ja...@apache.org>
- ASF Subversion and Git Services
On June 27, 2013, 7:04 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12136/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 7:04 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3245
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3245: non admin user not able to register template
>
> During registering template Admin only API parameter is set defaulted to false in the API layer if it is not set which causing user to fail registering template.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 13bd5da
> server/src/com/cloud/template/TemplateAdapterBase.java 7835680
>
> Diff: https://reviews.apache.org/r/12136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 12136: Fix for CLOUDSTACK-3245: non admin user not able
to register template
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12136/#review22487
-----------------------------------------------------------
Commit c8692f2e4a9760a58dbf457bf128fa484a491d0d in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c8692f2 ]
CLOUDSTACK-3245: non admin user not able to register template
Reviewed-by: Alena Prokharchyk
- ASF Subversion and Git Services
On June 27, 2013, 7:04 p.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12136/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 7:04 p.m.)
>
>
> Review request for cloudstack, Alena Prokharchyk and Abhinandan Prateek.
>
>
> Bugs: CLOUDSTACK-3245
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-3245: non admin user not able to register template
>
> During registering template Admin only API parameter is set defaulted to false in the API layer if it is not set which causing user to fail registering template.
>
>
> Diffs
> -----
>
> api/src/org/apache/cloudstack/api/command/user/template/RegisterTemplateCmd.java 13bd5da
> server/src/com/cloud/template/TemplateAdapterBase.java 7835680
>
> Diff: https://reviews.apache.org/r/12136/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Harikrishna Patnala
>
>