Re: [PR] [AURON #1409] Introduce Spark UI for auron [auron]

["guixiaowen (via GitHub)" <gi...@apache.org>]

guixiaowen commented on code in PR #1410:
URL: https://github.com/apache/auron/pull/1410#discussion_r2422528765


##########
spark-extension-shims-spark3/src/main/scala/org/apache/spark/sql/auron/ShimsImpl.scala:
##########
@@ -146,6 +148,49 @@ class ShimsImpl extends Shims with Logging {
     if (AuronConf.FORCE_SHUFFLED_HASH_JOIN.booleanConf()) {
       logWarning(s"${AuronConf.FORCE_SHUFFLED_HASH_JOIN.key} is not supported in $shimVersion")
     }
+
+  }
+
+  // set Auron spark ui if spark.auron.ui.enabled is true
+  override def onApplyingExtension(): Unit = {
+    logInfo(
+      " onApplyingExtension get ui_enabled : " + SparkEnv.get.conf
+        .get(AuronConf.UI_ENABLED.key, "true"))
+
+    if (SparkEnv.get.conf.get(AuronConf.UI_ENABLED.key, "true").equals("true")) {
+      val sparkContext = SparkContext.getOrCreate()

Review Comment:
   > This is too broad — using only SparkContext.getActive is sufficient for now. It’s acceptable in the current form and can be optimized later.
   
   @zuston z okok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@auron.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org