You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/28 07:40:17 UTC

[GitHub] [flink-connector-dynamodb] dannycranmer opened a new pull request, #7: [FLINK-29441] Setup (fix) convergence configuration

dannycranmer opened a new pull request, #7:
URL: https://github.com/apache/flink-connector-dynamodb/pull/7

   ## What is the purpose of the change
   
   Setup (fix) convergence configuration such that convergence is checked on CI
   
   ## Brief change log
   
   * Enable convergence check (still requires `-Pcheck-convergence` to run it)
   
   ## Verifying this change
   
   Run locally:
   * Enabled: `mvn validate -Pcheck-convergence`
   * Disabled: `mvn validate`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/a
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-dynamodb] dannycranmer commented on pull request #7: [FLINK-29441] Setup (fix) convergence configuration

Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #7:
URL: https://github.com/apache/flink-connector-dynamodb/pull/7#issuecomment-1260514041

   Can see convergence check running in action logs:
   ```
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (dependency-convergence) @ flink-connector-dynamodb-parent ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (dependency-convergence) @ flink-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (dependency-convergence) @ flink-sql-connector-dynamodb ---
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-dynamodb] dannycranmer commented on pull request #7: [FLINK-29441] Setup (fix) convergence configuration

Posted by GitBox <gi...@apache.org>.
dannycranmer commented on PR #7:
URL: https://github.com/apache/flink-connector-dynamodb/pull/7#issuecomment-1260534977

   > Should we enforce minimum required Maven version too? https://github.com/apache/flink-connector-elasticsearch/blob/main/pom.xml#L1001
   
   We already inherit all these:
   
   ```
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-maven-version) @ flink-sql-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-maven) @ flink-sql-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (ban-unsafe-snakeyaml) @ flink-sql-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (ban-unsafe-jackson) @ flink-sql-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (forbid-log4j-1) @ flink-sql-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (forbid-direct-akka-rpc-dependencies) @ flink-sql-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (forbid-direct-table-planner-dependencies) @ flink-sql-connector-dynamodb ---
   [INFO] --- maven-enforcer-plugin:3.0.0-M1:enforce (enforce-versions) @ flink-sql-connector-dynamodb ---
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-dynamodb] dannycranmer merged pull request #7: [FLINK-29441] Setup (fix) convergence configuration

Posted by GitBox <gi...@apache.org>.
dannycranmer merged PR #7:
URL: https://github.com/apache/flink-connector-dynamodb/pull/7


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-dynamodb] hlteoh37 commented on pull request #7: [FLINK-29441] Setup (fix) convergence configuration

Posted by GitBox <gi...@apache.org>.
hlteoh37 commented on PR #7:
URL: https://github.com/apache/flink-connector-dynamodb/pull/7#issuecomment-1260529635

   Should we enforce minimum required Maven version too? https://github.com/apache/flink-connector-elasticsearch/blob/main/pom.xml#L1001


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org