You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "liurenjie1024 (via GitHub)" <gi...@apache.org> on 2025/04/11 10:06:15 UTC
[I] Skip generate lock file for msrv check [iceberg-rust]
liurenjie1024 opened a new issue, #1195:
URL: https://github.com/apache/iceberg-rust/issues/1195
### Apache Iceberg Rust version
None
### Describe the bug
Currently in ci's msrv check, we have a step to generate lock file, which cause inconsistency between ci and local env.
### To Reproduce
See https://github.com/apache/iceberg-rust/blob/45312032665f21425215fe3cf26f53ca9c552a6b/.github/workflows/ci.yml#L142
### Expected behavior
We already checked in Cargo.lock, this is unncessary.
### Willingness to contribute
I can contribute a fix for this bug independently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Skip generate lock file for msrv check [iceberg-rust]
Posted by "xxchan (via GitHub)" <gi...@apache.org>.
xxchan commented on issue #1195:
URL: https://github.com/apache/iceberg-rust/issues/1195#issuecomment-2796544159
Yes, this is intentional, a.k.a. minimum-version-testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Skip generate lock file for msrv check [iceberg-rust]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo commented on issue #1195:
URL: https://github.com/apache/iceberg-rust/issues/1195#issuecomment-2796473325
Hi, our `Cargo.lock` file is already kept up to date, ensuring that we don’t break when using the latest versions of our dependencies. However, this test is designed to generate lock files using the minimal versions specified in `Cargo.toml`. This helps verify that the versions listed in `Cargo.toml` are correct and function as expected. It’s expected that this test does not use our existing lock files.
If this test fails, it indicates that the versions specified in `Cargo.toml` are incorrect. For example, specifying `uuid = "1.1"` is incorrect if users cannot build `iceberg-rust` with `uuid = "=1.1.0"` and instead require a higher version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Skip generate lock file for msrv check [iceberg-rust]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on issue #1195:
URL: https://github.com/apache/iceberg-rust/issues/1195#issuecomment-3262641348
Thoughts on removing the `-Z minimal-versions` when checking MSRV in CI?
https://github.com/apache/iceberg-rust/blob/7362bbdcf72910d95ee88940f229d2eea40b3fa1/.github/workflows/ci.yml#L155
[the docs](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#minimal-versions) mentions that the feature is not recommended anymore
I've ran an issue with this flag when upgrading datafusion from 47 -> 48. `-Z minimal-versions` will pull in very old versions of dependencies
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Skip generate lock file for msrv check [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 commented on issue #1195:
URL: https://github.com/apache/iceberg-rust/issues/1195#issuecomment-2796867407
Thanks @Xuanwo @xxchan 's discussion, it's reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [I] Skip generate lock file for msrv check [iceberg-rust]
Posted by "liurenjie1024 (via GitHub)" <gi...@apache.org>.
liurenjie1024 closed issue #1195: Skip generate lock file for msrv check
URL: https://github.com/apache/iceberg-rust/issues/1195
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org