You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jspwiki.apache.org by ju...@apache.org on 2019/10/10 21:34:26 UTC

[jspwiki] branch master updated: remove now redundant assertNull checks

This is an automated email from the ASF dual-hosted git repository.

juanpablo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jspwiki.git


The following commit(s) were added to refs/heads/master by this push:
     new 32f1d8b  remove now redundant assertNull checks
32f1d8b is described below

commit 32f1d8b995c02b754743243ee7e696f5dcc3d147
Author: juanpablo <ju...@apache.org>
AuthorDate: Thu Oct 10 23:34:08 2019 +0200

    remove now redundant assertNull checks
---
 .../src/test/java/org/apache/wiki/search/SearchManagerTest.java    | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/jspwiki-main/src/test/java/org/apache/wiki/search/SearchManagerTest.java b/jspwiki-main/src/test/java/org/apache/wiki/search/SearchManagerTest.java
index c831d01..1f7a935 100644
--- a/jspwiki-main/src/test/java/org/apache/wiki/search/SearchManagerTest.java
+++ b/jspwiki-main/src/test/java/org/apache/wiki/search/SearchManagerTest.java
@@ -97,7 +97,6 @@ public class SearchManagerTest {
         final Collection< SearchResult > res = new ArrayList<>();
         Awaitility.await( "testSimpleSearch" ).until( findsResultsFor( res, "mankind" ) );
 
-        Assertions.assertNotNull( res, "null result" );
         Assertions.assertEquals( 1, res.size(), "no pages" );
         Assertions.assertEquals( "TestPage", res.iterator().next().getPage().getName(), "page" );
         m_engine.deleteTestPage("TestPage");
@@ -112,7 +111,6 @@ public class SearchManagerTest {
         final Collection< SearchResult > res = new ArrayList<>();
         Awaitility.await( "testSimpleSearch2" ).until( findsResultsFor( res,"mankind" ) );
 
-        Assertions.assertNotNull( res, "null result" );
         Assertions.assertEquals( 1, res.size(), "no pages" );
         Assertions.assertEquals( "TestPage", res.iterator().next().getPage().getName(), "page" );
         m_engine.deleteTestPage( "TestPage" );
@@ -131,7 +129,6 @@ public class SearchManagerTest {
         Awaitility.await( "testSimpleSearch3" ).until( findsResultsFor( res, "Babylon" ) );
         res = m_mgr.findPages( "mankind", ctx ); // check for text present in 1st m_engine.saveText() but not in 2nd
 
-        Assertions.assertNotNull( res, "found results" );
         Assertions.assertEquals( 0, res.size(), "empty results" );
 
         res = m_mgr.findPages( "Babylon", ctx );
@@ -152,7 +149,6 @@ public class SearchManagerTest {
         Collection< SearchResult > res = new ArrayList<>();
         Awaitility.await( "testSimpleSearch4" ).until( findsResultsFor( res, "mankind" ) );
 
-        Assertions.assertNotNull( res, "found results" );
         Assertions.assertEquals( 1, res.size(), "result not found" );
 
         m_engine.saveText( ctx, "[{ALLOW view Authenticated}] It was the dawn of the third age of mankind... page is blocked" );
@@ -172,7 +168,6 @@ public class SearchManagerTest {
         final Collection< SearchResult > res = new ArrayList<>();
         Awaitility.await( "testTitleSearch" ).until( findsResultsFor( res, "Test" ) );
 
-        Assertions.assertNotNull( res, "null result" );
         Assertions.assertEquals( 1, res.size(), "no pages" );
         Assertions.assertEquals( "TestPage", res.iterator().next().getPage().getName(), "page" );
         m_engine.deleteTestPage("TestPage");
@@ -186,7 +181,6 @@ public class SearchManagerTest {
         final Collection< SearchResult > res = new ArrayList<>();
         Awaitility.await( "testTitleSearch2" ).until( findsResultsFor( res, "TestPage" ) );
 
-        Assertions.assertNotNull( res, "null result" );
         Assertions.assertEquals( 1, res.size(), "no pages" );
         Assertions.assertEquals( "TestPage", res.iterator().next().getPage().getName(), "page" );
         m_engine.deleteTestPage("TestPage");
@@ -201,7 +195,6 @@ public class SearchManagerTest {
         final Collection< SearchResult > res = new ArrayList<>();
         Awaitility.await( "testKeywordsSearch" ).until( findsResultsFor( res, "perry" ) );
 
-        Assertions.assertNotNull( res, "null result" );
         Assertions.assertEquals( 1, res.size(), "no pages" );
         Assertions.assertEquals( "TestPage", res.iterator().next().getPage().getName(), "page" );
         m_engine.deleteTestPage("TestPage");