You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "casaroli (via GitHub)" <gi...@apache.org> on 2026/10/18 23:22:18 UTC
[PR] testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method. [nuttx-apps]
casaroli opened a new pull request, #3879:
URL: https://github.com/apache/nuttx-apps/pull/3879
## Summary
The poll() method of a driver takes `struct pollfd_s` from `nuttx/poll.h` after apache/nuttx#20796, where `struct pollfd` gets the POSIX layout and is only for user code. `testing/drivers/rpmsgdev/testdev.c` registers a driver with a poll method, so it follows the change.
The first commit fixes older style errors that `tools/checkpatch.sh` reports in the file: the indentation of two switch statements and an if/else block, and the typo "regist" in the usage text. The code does not change.
depends-on: apache/nuttx/pull/20796
## Impact
`testdev.c` builds with the new `struct pollfd`. No change in behaviour.
## Testing
`qemu-armv8a:rpserver` with `CONFIG_DEV_RPMSG`, `CONFIG_DEV_RPMSG_SERVER` and `CONFIG_RPMSGDEV_TEST`, against the nuttx PR: `testdev.c` compiles. The only compiler message is an older `-Wformat` warning at line 363 (`%d` for an `ssize_t`), which master also has on 64-bit targets. `tools/checkpatch.sh -c -u -m -g` passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method. [nuttx-apps]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3879:
URL: https://github.com/apache/nuttx-apps/pull/3879#issuecomment-6260778246
<!-- nuttx-depends-on-bot run-39185920179 -->
### 🔗 Cross-repo PR dependencies
The read-only Build run reported the following dependent PR(s) and fetched head SHA(s):
- https://github.com/apache/nuttx/pull/20796 @ 26a40f9164
- https://github.com/apache/nuttx-apps/pull/3878 @ 902ad27529
- https://github.com/apache/nuttx/pull/20802 @ 01f333f250
CI run: https://github.com/apache/nuttx-apps/actions/runs/39185920179
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method. [nuttx-apps]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3879:
URL: https://github.com/apache/nuttx-apps/pull/3879#issuecomment-6282849657
<!-- nuttx-depends-on-bot run-39310456556 -->
### 🔗 Cross-repo PR dependencies
The read-only Build run reported the following dependent PR(s) and fetched head SHA(s):
- https://github.com/apache/nuttx/pull/20796 @ b02ec1eca7
CI run: https://github.com/apache/nuttx-apps/actions/runs/39310456556
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method. [nuttx-apps]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli closed pull request #3879: testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method.
URL: https://github.com/apache/nuttx-apps/pull/3879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method. [nuttx-apps]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #3879:
URL: https://github.com/apache/nuttx-apps/pull/3879#issuecomment-6256880124
<!-- nuttx-depends-on-bot run-39176233234 -->
### 🔗 Cross-repo PR dependencies
The read-only Build run reported the following dependent PR(s) and fetched head SHA(s):
- https://github.com/apache/nuttx/pull/20796 @ 26a40f9164
CI run: https://github.com/apache/nuttx-apps/actions/runs/39176233234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method. [nuttx-apps]
Posted by "casaroli (via GitHub)" <gi...@apache.org>.
casaroli closed pull request #3879: testing/drivers/rpmsgdev: Use struct pollfd_s in the poll method.
URL: https://github.com/apache/nuttx-apps/pull/3879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org