You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "wzx140 (via GitHub)" <gi...@apache.org> on 2025/09/25 04:12:18 UTC
[PR] [FLINK-38432][python] Fix missing finish/reset for keyWriter/valueWriter in ArrowMapWriter [flink]
wzx140 opened a new pull request, #27038:
URL: https://github.com/apache/flink/pull/27038
## What is the purpose of the change
The finish and reset methods in org.apache.flink.table.runtime.arrow.writers.MapWriter should be implemented in the same way as in org.apache.flink.table.runtime.arrow.writers.RowWriter.
Otherwise, the following sequence will lead to incorrect behavior:
```
MapWriter.write
// Arrow data is right
MapWriter.finish
MapWriter.reset
MapWriter.write
// Arrow data is wrong, map is null
MapWriter.finish
```
## Brief change log
Add finish/reset for keyWriter/valueWriter in ArrowMapWriter.
## Verifying this change
Add UT
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38432][python] Fix missing finish/reset for keyWriter/valueWriter in ArrowMapWriter [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #27038:
URL: https://github.com/apache/flink/pull/27038#issuecomment-3332044794
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c364a49dde82815ece9d26c876842b8664e9cca5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c364a49dde82815ece9d26c876842b8664e9cca5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c364a49dde82815ece9d26c876842b8664e9cca5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38432][python] Fix missing finish/reset for keyWriter/valueWriter in ArrowMapWriter [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #27038: [FLINK-38432][python] Fix missing finish/reset for keyWriter/valueWriter in ArrowMapWriter
URL: https://github.com/apache/flink/pull/27038
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38432][python] Fix missing finish/reset for keyWriter/valueWriter in ArrowMapWriter [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27038:
URL: https://github.com/apache/flink/pull/27038#issuecomment-3796077134
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-38432][python] Fix missing finish/reset for keyWriter/valueWriter in ArrowMapWriter [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27038:
URL: https://github.com/apache/flink/pull/27038#issuecomment-3691003434
This PR is being marked as stale since it has not had any activity in the last 90 days.
If you would like to keep this PR alive, please leave a comment asking for a review.
If the PR has merge conflicts, update it with the latest from the base branch.
If you are having difficulty finding a reviewer, please reach out to the
community, contact details can be found here: https://flink.apache.org/what-is-flink/community/
If this PR is no longer valid or desired, please feel free to close it.
If no activity occurs in the next 30 days, it will be automatically closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org